Skip to content

ci: new version of husky no longer need npx#10030

Merged
benelan merged 1 commit intodevfrom
benelan/husky-no-longer-need-npx
Aug 9, 2024
Merged

ci: new version of husky no longer need npx#10030
benelan merged 1 commit intodevfrom
benelan/husky-no-longer-need-npx

Conversation

@benelan
Copy link
Copy Markdown
Contributor

@benelan benelan commented Aug 9, 2024

Summary

Husky adds node_modules/.bin to PATH starting in v9, so npx is no longer required in the hook scripts.

ref: https://github.com/typicode/husky/releases/tag/v9.0.1#how-to-migrate

@benelan benelan requested a review from jcfranco as a code owner August 9, 2024 20:39
@github-actions github-actions Bot added the chore Issues with changes that don't modify src or test files. label Aug 9, 2024
@benelan benelan added the skip visual snapshots Pull requests that do not need visual regression testing. label Aug 9, 2024
@benelan
Copy link
Copy Markdown
Contributor Author

benelan commented Aug 9, 2024

pushing this through because an icon designer is getting an error trying to commit from GitHub Desktop:

.husky/pre-commit: line 3: npx: command not found
husky - pre-commit script failed (code 127)
husky - command not found in PATH=node_modules/.bin:/Applications/GitHub Desktop.app/Contents/Resources/app/git/libexec/git-core: /usr/bin:/bin:/usr/sbin:/sbin

cc @jcfranco

@benelan benelan merged commit 3b7029a into dev Aug 9, 2024
@benelan benelan deleted the benelan/husky-no-longer-need-npx branch August 9, 2024 20:54
@github-actions github-actions Bot added this to the 2024-08-27 - Aug Release milestone Aug 9, 2024
benelan added a commit that referenced this pull request Aug 13, 2024
…to-monorepo

* origin/dev: (37 commits)
  chore: release next
  fix(tree,tree-item): replace checkbox with div and a11y attributes (#9849)
  feat(combobox-item): add `heading` property (deprecates `textLabel`) and add `label` property (#9987)
  chore: stop requesting review from ben/franco for all PRs (#10040)
  feat: add close-caption, transcript, flag, and flag-slash (#10039)
  build(deps): update dependency @cspell/eslint-plugin to v8.13.2 (#10036)
  build(deps): update angular-cli monorepo to v18.1.4 (#10035)
  build(deps): clean up ui-icon dependencies (#10024)
  build: update browserslist db (#10033)
  docs: update component READMEs (#10034)
  ci: fix chromatic and pr-semantic check trigger events (#10041)
  chore: release next
  fix(label): prevent focusing and toggling elements slotted within a label when a text selection occurs (#9990)
  build(deps): update dependency @floating-ui/dom to v1.6.9 (#10025)
  build(deps): update dependency postcss to v8.4.41 (#10027)
  ci: new version of husky no longer need npx (#10030)
  build(deps): update dependency lerna to v8.1.8 (#10026)
  build(deps): update dependency chromatic to v11.7.0 (#9995)
  build(deps): update dependency eslint-plugin-jsdoc to v48.11.0 (#9997)
  chore: release next
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Issues with changes that don't modify src or test files. skip visual snapshots Pull requests that do not need visual regression testing.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant