Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added info about working_dir when using orion info CLI #430

Merged
merged 2 commits into from
Aug 7, 2020
Merged

added info about working_dir when using orion info CLI #430

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b5af240
added info about working_dir when using orion info CLI
mirkobronzi Jul 24, 2020
0cdb8fa
fixed non passing testa (after modification to the printed output)
mirkobronzi Jul 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/orion/core/utils/format_terminal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,6 +258,7 @@ def format_commandline(experiment):
{title}
pool size: {experiment.pool_size}
max trials: {experiment.max_trials}
working dir: {experiment.working_dir}
"""


Expand Down
2 changes: 1 addition & 1 deletion src/orion/core/worker/experiment.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,7 +409,7 @@ class ExperimentView(object):

# Attributes
valid_attributes = (["_id", "name", "refers", "metadata", "pool_size", "max_trials",
"version", "space"] +
"version", "space", "working_dir"] +
# Properties
["id", "node", "is_done", "algorithms", "stats", "configuration"] +
# Methods
Expand Down
4 changes: 4 additions & 0 deletions tests/unittests/core/cli/test_info.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -395,11 +395,13 @@ def test_format_config(monkeypatch):
experiment = DummyExperiment()
experiment.pool_size = 10
experiment.max_trials = 100
experiment.working_dir = "working_dir"
assert format_config(experiment) == """\
Config
======
pool size: 10
max trials: 100
working dir: working_dir
"""


Expand Down Expand Up @@ -574,6 +576,7 @@ def test_format_info(algorithm_dict, dummy_trial):
experiment.metadata = {'user_args': commandline}
experiment.pool_size = 10
experiment.max_trials = 100
experiment.working_dir = "working_dir"
experiment.configuration = {'algorithms': algorithm_dict}

space = SpaceBuilder().build(
Expand Down Expand Up @@ -636,6 +639,7 @@ def test_format_info(algorithm_dict, dummy_trial):
======
pool size: 10
max trials: 100
working dir: working_dir


Algorithm
Expand Down