Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added info about working_dir when using orion info CLI #430

Merged
merged 2 commits into from
Aug 7, 2020

Conversation

mirkobronzi
Copy link
Contributor

@mirkobronzi mirkobronzi commented Jul 24, 2020

Description

When using the CLI command orion info, it will now print the working_dir variable.

E.g.,

Config

pool size: 1
max trials: 2
working dir: orion_working_dir

Changes

Just added working_dir to the list of variables printed under "Config"

Checklist

Tests

  • [x ] I added corresponding tests for bug fixes and new features. If possible, the tests fail without the changes
  • [x ] All new and existing tests are passing ($ tox -e py38; replace 38 by your Python version if necessary)

Documentation

  • [x ] I have updated the relevant documentation related to my changes

Quality

  • I have read the CONTRIBUTING doc
  • [ x] My commits messages follow this format
  • [x ] My code follows the style guidelines ($ tox -e lint)

Further comments

@codecov-commenter
Copy link

Codecov Report

Merging #430 into develop will increase coverage by 0.59%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #430      +/-   ##
===========================================
+ Coverage    47.52%   48.11%   +0.59%     
===========================================
  Files           70       76       +6     
  Lines        13009    13369     +360     
  Branches       322      328       +6     
===========================================
+ Hits          6183     6433     +250     
- Misses        6800     6919     +119     
+ Partials        26       17       -9     
Impacted Files Coverage Δ
tests/unittests/core/cli/test_info.py 20.07% <0.00%> (-0.15%) ⬇️
tests/unittests/client/test_experiment_client.py 55.78% <0.00%> (-2.15%) ⬇️
tests/unittests/storage/test_storage.py 16.05% <0.00%> (-1.48%) ⬇️
tests/unittests/core/worker/test_consumer.py 30.12% <0.00%> (-0.77%) ⬇️
tests/unittests/storage/test_legacy.py 31.81% <0.00%> (-0.59%) ⬇️
tests/unittests/client/test_client.py 99.60% <0.00%> (-0.41%) ⬇️
tests/functional/algos/test_algos.py 100.00% <0.00%> (ø)
tests/functional/commands/test_info_command.py 100.00% <0.00%> (ø)
tests/functional/commands/test_insert_command.py 100.00% <0.00%> (ø)
tests/unittests/analysis/test_regret.py 100.00% <0.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d192c02...0cdb8fa. Read the comment docs.

Copy link
Member

@bouthilx bouthilx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bouthilx bouthilx merged commit 47f6cdd into Epistimio:develop Aug 7, 2020
@bouthilx bouthilx added this to the v0.1.9 milestone Nov 5, 2020
This was referenced Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants