Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show proper yaml syntax in resolve_config deprecation warnings containing None #391

Merged
merged 3 commits into from
Jun 16, 2020

Conversation

vmichals
Copy link
Contributor

Description

Fix #390

Changes

Instead of printing the repr(), the suggested change is now passed through yaml.dump()

Checklist

  • does the chosen indentation fit all/most use cases?

Quality

  • I have read the CONTRIBUTING doc
  • My commits messages follow this format
  • My code follows the style guidelines ($ tox -e lint)

@codecov-commenter
Copy link

codecov-commenter commented May 20, 2020

Codecov Report

Merging #391 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #391   +/-   ##
========================================
  Coverage    47.30%   47.30%           
========================================
  Files           67       67           
  Lines        12932    12932           
  Branches       321      321           
========================================
  Hits          6117     6117           
  Misses        6790     6790           
  Partials        25       25           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e68a41f...f77d29b. Read the comment docs.

@Thomsch
Copy link
Contributor

Thomsch commented May 25, 2020

Thank you for your contribution @vmichals !

@bouthilx
Copy link
Member

bouthilx commented Jun 8, 2020

Closing and re-opening to try fixing travis ci issue. I don't know why it's appearing twice here.

@bouthilx bouthilx closed this Jun 8, 2020
@bouthilx bouthilx reopened this Jun 8, 2020
@Thomsch Thomsch merged commit fd950cc into Epistimio:develop Jun 16, 2020
This was referenced Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecation warning in resolve_config suggests to write None instead of none into config file
4 participants