Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation warning in resolve_config suggests to write None instead of none into config file #390

Closed
vmichals opened this issue May 20, 2020 · 1 comment · Fixed by #391
Labels
bug Indicates an unexpected problem or unintended behavior medium The bug breaks a feature but it can still be used or causes a confusing user experience

Comments

@vmichals
Copy link
Contributor

vmichals commented May 20, 2020

Describe the bug
The deprecation warning raised here when using a config with the following content:

algorithms:
    random:
        seed: null

suggests to change the config to the following:

experiment:
  algorithms: {'random': {'seed': None}}

The None should be null in yaml/json files.

Expected behavior
The deprecation warning should show null (proper yaml syntax).

Steps to reproduce
See the example config in the bug description above

Environment (please complete the following information):

  • OS: Ubuntu 18.04
  • Python version: 3.6.9
  • Oríon version: 0.1.7
  • Database: PickleDB

Possible solution
See PR #391

Instead of calling repr(backward_value) use yaml.dump(backward_value) here

@vmichals vmichals added the bug Indicates an unexpected problem or unintended behavior label May 20, 2020
@Thomsch
Copy link
Contributor

Thomsch commented May 22, 2020

Thank you for reporting this bug!
We'll take a look at your solution as soon as possible!

Thanks again!

@Thomsch Thomsch added the medium The bug breaks a feature but it can still be used or causes a confusing user experience label Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behavior medium The bug breaks a feature but it can still be used or causes a confusing user experience
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants