Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic positioning of the calendar #44

Closed
sorbing opened this issue Oct 24, 2013 · 10 comments
Closed

Automatic positioning of the calendar #44

sorbing opened this issue Oct 24, 2013 · 10 comments
Milestone

Comments

@sorbing
Copy link

sorbing commented Oct 24, 2013

Depending on the position of the input element, the calendar may be beyond the window. It will be great if the plugin automatically learns to position the block with calendar.

Eonasdan added a commit that referenced this issue Oct 28, 2013
@Eonasdan
Copy link
Owner

oops! referenced the wrong issue in the commit. This hasn't been fixed yet. I was working on something but right now my fix doesn't quite work.

@nobane
Copy link

nobane commented Nov 11, 2013

+1 for a fix for this. Until the plugin can detect being out of window, try adding a large padding-bottom (about 200px) below your form. I am using the datetimepicker inside bootstrap's modal overlay and the padding-bottom allows the user to have the ability to scroll down enough to view the calendar.

@nghenglim
Copy link

+1 same problem here. Perhaps its some crash of bootstrap 3 with jquery ui.

@lubert
Copy link

lubert commented Jan 13, 2014

I'm working on a fix for this, starting from the commented out stub on line 229. I modified the CSS a little to allow the caret to be positioned correctly. I'll run the tests later to make sure I haven't broken anything before sending a pull request.

@Eonasdan
Copy link
Owner

@lubert bless you sir

@lubert
Copy link

lubert commented Jan 14, 2014

@Eonasdan
I noticed there aren't any tests in the master branch, only version1. Are the tests in version1 branch up to date with master?

@Eonasdan
Copy link
Owner

no the tests would be from the original fork for version1. The master is currently 2.1.20 which has largely been rewritten to use momentjs

@lubert
Copy link

lubert commented Jan 14, 2014

Ok, having difficulty getting the tests to run on OSX and an ubuntu vm instance, I'm going to send a pull request for the master branch for now at least

@Eonasdan
Copy link
Owner

Eonasdan commented Mar 1, 2014

This will get fixed in the next release

@Eonasdan Eonasdan modified the milestone: 3.0.0 Mar 3, 2014
Eonasdan added a commit that referenced this issue Mar 3, 2014
## 3.0.0
## **Breaking changes in this update! Pay attention!!**
* Fix for #170, #179, #183: Changed event to `dp.-` options load as
`data-date-OPTION` instead of `data-OPTION`. This should fix the double
change event firing.
* Fix for #192: `setDate` now fires `dp.change`
* Fix for #182: Picker will **not** set the default date if the input
field has a value
* Fix for #169: Seconds doesn't get reset when changing the date (Thanks
to PR #174)
* Fix for #168 z-index fix for BS modal
* Fix for #155 Picker properly displays the active year and month
* Fix for #154 CSS update to fix the collapse jump
* Fix for #150 and #75 `minViewMode` and `viewMode` work properly
* Fix for #44 Finally! It's here!! Thanks to @ruiwei and his code on
#210 picker will adjust the positioning of the widget.

#### **Manually merged PR**
* #178 When using `minuteStepping` the minute select grid will only show
available steppings
* #195, #197 Using the `data-OPTION` has been changed to
`data-date-OPTION`. These options are expected to be on the
`input-group` if you're using the `form-group` **or** the input field
* #184 The option `sideBySide` change be used to display both the d and
the timepicker side by side

#### **Other Changes**
* Changed picker width to 300px if using seconds and am/pm
* Added option `useCurrent`, thanks to @ruiwei. When true, picker will
set the value to the current date/time (respects picker's format)
* Added option `showToday`, thanks to @ruiwei. When true, picker will
display a small arrow to indicate today's date.
* Changed `startDate` to `minDate` and `endDate` to `maxDate` to make it
more clear what these options do.
@Eonasdan
Copy link
Owner

Eonasdan commented Mar 3, 2014

Please check the Staging branch to verify your issue(s) have been resolved.

kikonen pushed a commit to kikonen/bootstrap-datetimepicker that referenced this issue Jan 2, 2017
@ghost ghost locked and limited conversation to collaborators Jun 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants