-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatic positioning of the calendar #44
Comments
oops! referenced the wrong issue in the commit. This hasn't been fixed yet. I was working on something but right now my fix doesn't quite work. |
+1 for a fix for this. Until the plugin can detect being out of window, try adding a large padding-bottom (about 200px) below your form. I am using the datetimepicker inside bootstrap's modal overlay and the padding-bottom allows the user to have the ability to scroll down enough to view the calendar. |
+1 same problem here. Perhaps its some crash of bootstrap 3 with jquery ui. |
I'm working on a fix for this, starting from the commented out stub on line 229. I modified the CSS a little to allow the caret to be positioned correctly. I'll run the tests later to make sure I haven't broken anything before sending a pull request. |
@lubert bless you sir |
@Eonasdan |
no the tests would be from the original fork for version1. The master is currently 2.1.20 which has largely been rewritten to use momentjs |
Ok, having difficulty getting the tests to run on OSX and an ubuntu vm instance, I'm going to send a pull request for the master branch for now at least |
This will get fixed in the next release |
## 3.0.0 ## **Breaking changes in this update! Pay attention!!** * Fix for #170, #179, #183: Changed event to `dp.-` options load as `data-date-OPTION` instead of `data-OPTION`. This should fix the double change event firing. * Fix for #192: `setDate` now fires `dp.change` * Fix for #182: Picker will **not** set the default date if the input field has a value * Fix for #169: Seconds doesn't get reset when changing the date (Thanks to PR #174) * Fix for #168 z-index fix for BS modal * Fix for #155 Picker properly displays the active year and month * Fix for #154 CSS update to fix the collapse jump * Fix for #150 and #75 `minViewMode` and `viewMode` work properly * Fix for #44 Finally! It's here!! Thanks to @ruiwei and his code on #210 picker will adjust the positioning of the widget. #### **Manually merged PR** * #178 When using `minuteStepping` the minute select grid will only show available steppings * #195, #197 Using the `data-OPTION` has been changed to `data-date-OPTION`. These options are expected to be on the `input-group` if you're using the `form-group` **or** the input field * #184 The option `sideBySide` change be used to display both the d and the timepicker side by side #### **Other Changes** * Changed picker width to 300px if using seconds and am/pm * Added option `useCurrent`, thanks to @ruiwei. When true, picker will set the value to the current date/time (respects picker's format) * Added option `showToday`, thanks to @ruiwei. When true, picker will display a small arrow to indicate today's date. * Changed `startDate` to `minDate` and `endDate` to `maxDate` to make it more clear what these options do.
Please check the Staging branch to verify your issue(s) have been resolved. |
Depending on the position of the
input
element, the calendar may be beyond the window. It will be great if the plugin automatically learns to position the block with calendar.The text was updated successfully, but these errors were encountered: