Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why does changing month fires change event? #150

Closed
escobar5 opened this issue Jan 28, 2014 · 2 comments
Closed

Why does changing month fires change event? #150

escobar5 opened this issue Jan 28, 2014 · 2 comments
Milestone
3.0.0

Comments

@escobar5
Copy link

When you switch to month view and select a month the control triggers the change.dp event, but the date hasn't changed, I haven't selected the day.

Is this the right behavior?

Thanks
@escobar5 escobar5 mentioned this issue Jan 30, 2014
Closed
@Eonasdan
Copy link
Owner

Eonasdan commented Mar 1, 2014

because it is possible to set the picker to only show month/year. In the next release this will work again and set the date

@Eonasdan Eonasdan modified the milestone: 3.0.0 Mar 3, 2014
Eonasdan added a commit that referenced this issue Mar 3, 2014
@Eonasdan
Staging v3 changes
d2f75f0 
## 3.0.0
## **Breaking changes in this update! Pay attention!!**
* Fix for #170, #179, #183: Changed event to `dp.-` options load as
`data-date-OPTION` instead of `data-OPTION`. This should fix the double
change event firing.
* Fix for #192: `setDate` now fires `dp.change`
* Fix for #182: Picker will **not** set the default date if the input
field has a value
* Fix for #169: Seconds doesn't get reset when changing the date (Thanks
to PR #174)
* Fix for #168 z-index fix for BS modal
* Fix for #155 Picker properly displays the active year and month
* Fix for #154 CSS update to fix the collapse jump
* Fix for #150 and #75 `minViewMode` and `viewMode` work properly
* Fix for #44 Finally! It's here!! Thanks to @ruiwei and his code on
#210 picker will adjust the positioning of the widget.

#### **Manually merged PR**
* #178 When using `minuteStepping` the minute select grid will only show
available steppings
* #195, #197 Using the `data-OPTION` has been changed to
`data-date-OPTION`. These options are expected to be on the
`input-group` if you're using the `form-group` **or** the input field
* #184 The option `sideBySide` change be used to display both the d and
the timepicker side by side

#### **Other Changes**
* Changed picker width to 300px if using seconds and am/pm
* Added option `useCurrent`, thanks to @ruiwei. When true, picker will
set the value to the current date/time (respects picker's format)
* Added option `showToday`, thanks to @ruiwei. When true, picker will
display a small arrow to indicate today's date.
* Changed `startDate` to `minDate` and `endDate` to `maxDate` to make it
more clear what these options do.
@Eonasdan
Copy link
Owner

Eonasdan commented Mar 3, 2014

Please check the Staging branch to verify your issue(s) have been resolved.

@Eonasdan Eonasdan closed this as completed Mar 3, 2014
@Eonasdan Eonasdan reopened this Mar 3, 2014
@ghost ghost locked and limited conversation to collaborators Jun 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
2 participants
@escobar5 @Eonasdan