-
Notifications
You must be signed in to change notification settings - Fork 0
Enable registration #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
giordano
wants to merge
19
commits into
main
Choose a base branch
from
mg/register
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 18 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
909f8e3
Start preparing code for registration
giordano 21a45a8
DROP ME: skip all GPU platforms and debug builds
giordano 7e5eb23
Add deploy_repo argument to push_jll_package
giordano cb4612a
More colour
giordano 268c085
DROP ME: debug
giordano 8f12dd6
DROP ME: test hello world
giordano a7b4ac2
Save cache
giordano af01815
Set repositories for the app
giordano 80fbade
Decouple upstream registry and its fork during registration
giordano 8b834ba
Use different token for registration PR
giordano 28077e8
Update Manifest.toml
wsmoses aba40af
Fix registry URL authentication in register_package.jl
wsmoses 3701cda
hello world c2
wsmoses ac584fd
fix
wsmoses a5ecc71
Update build_tarballs.jl
wsmoses 0a98281
fix
wsmoses 0e55e55
1.0 baby
wsmoses 71849f7
fix
wsmoses 8cfe8af
Finalise everything and bump Reactant commit & version
giordano File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,6 +2,11 @@ name: "Build Reactant_jll" | |
|
|
||
| on: | ||
| workflow_call: | ||
| secrets: | ||
| ENZYMEAD_BOT_ID: | ||
| required: true | ||
| ENZYMEAD_BOT_PRIVATE_KEY: | ||
| required: true | ||
| inputs: | ||
| julia_version: | ||
| description: 'Julia version' | ||
|
|
@@ -17,7 +22,7 @@ on: | |
| description: 'The project to build' | ||
| required: false | ||
| type: string | ||
| default: 'R/Reactant' | ||
| default: 'H/HelloWorldC2' | ||
| reactantbuilder_ref: | ||
| description: 'The Git ref of EnzymeAD/ReactantBuilder to check out (leave empty to use the default)' | ||
| required: false | ||
|
|
@@ -212,10 +217,36 @@ jobs: | |
| needs: build-platforms | ||
|
|
||
| steps: | ||
| - uses: actions/create-github-app-token@v2 | ||
| id: generate_token | ||
| with: | ||
| app-id: "${{ secrets.ENZYMEAD_BOT_ID }}" | ||
| private-key: "${{ secrets.ENZYMEAD_BOT_PRIVATE_KEY }}" | ||
| owner: EnzymeAD | ||
| repositories: | | ||
| Reactant_jll.jl | ||
| HelloWorldC_jll.jl | ||
| HelloWorldC2_jll.jl | ||
| ReactantBuilder | ||
| General | ||
| - uses: actions/checkout@v5 | ||
| with: | ||
| repository: 'EnzymeAD/ReactantBuilder' | ||
| ref: ${{ inputs.reactantbuilder_ref == '' && github.sha || inputs.reactantbuilder_ref }} | ||
| - name: Set JULIA_PROJECT | ||
| # We have to use `${GITHUB_WORKSPACE}` instead of `github.workspace` because GitHub | ||
| # is terrible and the two don't match inside containers: | ||
| # https://github.com/actions/runner/issues/2058 | ||
| run: | ||
| echo "JULIA_PROJECT=${GITHUB_WORKSPACE}/.ci" >> "${GITHUB_ENV}" | ||
| - name: Set and create PRODUCTS_DIR | ||
| # We have to use `${GITHUB_WORKSPACE}` instead of `github.workspace` because GitHub | ||
| # is terrible and the two don't match inside containers: | ||
| # https://github.com/actions/runner/issues/2058 | ||
| run: | | ||
| PRODUCTS_DIR=${{ inputs.build_project }}/products | ||
| mkdir -p "${PRODUCTS_DIR}" | ||
| echo "PRODUCTS_DIR=${PRODUCTS_DIR}" >> "${GITHUB_ENV}" | ||
| - uses: julia-actions/setup-julia@v2 | ||
| with: | ||
| version: '${{ inputs.julia_version }}' | ||
|
|
@@ -225,13 +256,42 @@ jobs: | |
| - uses: actions/download-artifact@v6 | ||
| with: | ||
| merge-multiple: true | ||
| path: ${{ env.PRODUCTS_DIR }} | ||
| - name: Change Reactant commit | ||
| run: | | ||
| if [[ -n "${{ inputs.reactant_commit }}" ]]; then | ||
| echo 'Changing Reactant commit to ${{ inputs.reactant_commit }}...' | ||
| sed -i 's/reactant_commit = ".*"/reactant_commit = "'${{ inputs.reactant_commit }}'"/' R/Reactant/build_tarballs.jl | ||
| fi | ||
| - name: Check | ||
| - name: Set up git | ||
| run: | | ||
| git config --global user.name "$enzymead-bot[bot]" | ||
| git config --global user.email "238314553+enzymead-bot[bot]@users.noreply.github.com" | ||
| - name: Instantiate environment | ||
| timeout-minutes: 20 | ||
| shell: julia --color=yes {0} | ||
| run: | | ||
| using Pkg | ||
| Pkg.instantiate() | ||
| - name: Generate meta.json | ||
| run: | | ||
| pwd | ||
| ls -lhrt | ||
| julia --color=yes --compile=min ./build_tarballs.jl --meta-json=$(basename ${{ inputs.build_project }}).meta.json | ||
| working-directory: ${{ inputs.build_project }} | ||
| env: | ||
| GITHUB_TOKEN: | ||
| - name: Register | ||
| run: | | ||
| julia --color=yes ${JULIA_PROJECT}/register_package.jl "$(basename ${{ inputs.build_project }}).meta.json" --verbose | ||
| working-directory: ${{ inputs.build_project }} | ||
| env: | ||
| GITHUB_TOKEN: ${{ steps.generate_token.outputs.token }} | ||
| JLBUILD_GITHUB_TOKEN: ${{ secrets.JLBUILD_GITHUB_TOKEN }} | ||
| JULIA_DEBUG: BinaryBuilder | ||
|
||
| - name: Save Julia depot cache on cancel or failure | ||
| id: julia-cache-save | ||
| if: cancelled() || failure() | ||
| uses: actions/cache/save@v4 | ||
| with: | ||
| path: | | ||
| ${{ steps.julia-cache.outputs.cache-paths }} | ||
| key: ${{ steps.julia-cache.outputs.cache-key }} | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,3 +20,4 @@ jobs: | |
| strategy: | ||
| fail-fast: false | ||
| uses: ./.github/workflows/build-reactant-reusable.yml | ||
| secrets: inherit | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reminder we need to revert this at the end