Skip to content

Enable registration #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

Enable registration #5

wants to merge 19 commits into from

Conversation

@giordano
Copy link
Member

@giordano giordano commented Oct 26, 2025

No description provided.

@giordano giordano force-pushed the mg/register branch 13 times, most recently from 915a6af to 67e263b Compare October 29, 2025 19:59
@giordano
Copy link
Member Author

giordano commented Oct 29, 2025 

ERROR: LoadError: GitError(Code:ERROR, Class:HTTP, unexpected http status code: 403)
Stacktrace:
 [1] macro expansion
   @ /opt/hostedtoolcache/julia/1.7.3/x64/share/julia/stdlib/v1.7/LibGit2/src/error.jl:110 [inlined]
 [2] push(rmt::LibGit2.GitRemote, refspecs::Vector{String}; force::Bool, options::LibGit2.PushOptions)
   @ LibGit2 /opt/hostedtoolcache/julia/1.7.3/x64/share/julia/stdlib/v1.7/LibGit2/src/remote.jl:324

OK, now I'm puzzled, the app should be able to push to https://github.com/EnzymeAD/Reactant_jll.jl

@giordano
Copy link
Member Author

giordano commented Oct 29, 2025

https://github.com/JuliaPackaging/BinaryBuilder.jl/blob/6044a24203055ac18b8251da50b04d8f53efc007/src/AutoBuild.jl#L1783-L1788. deploy_repo is coming from https://github.com/JuliaPackaging/BinaryBuilder.jl/blob/6044a24203055ac18b8251da50b04d8f53efc007/src/AutoBuild.jl#L1768, we need to make sure we're actually passing it, instead of relying on the default value, which is the wrong organisation.

@giordano
Copy link
Member Author

giordano commented Oct 29, 2025

Ok, that was easy:

ReactantBuilder/.ci/register_package.jl

Line 117 in 67e263b

BinaryBuilder.push_jll_package(name, build_version)
We're calling the push function directly, and not passing the right repo name.

@giordano
Copy link
Member Author

giordano commented Oct 30, 2025 •
edited
Loading

Ok, this is still failing after passing the repo name, I'll need to sprinkle some debugging information to understand what's going on. This won't happen soon though.

@giordano giordano force-pushed the mg/register branch 3 times, most recently from d73344d to f43b275 Compare November 7, 2025 19:38
@giordano
Copy link
Member Author

giordano commented Nov 7, 2025 •
edited
Loading

Ok, at this point I'm totally lost: https://github.com/EnzymeAD/ReactantBuilder/actions/runs/19179272199/job/54831862183?pr=5#step:13:23

┌ Debug: Pushing the JLL
│   wrapper_repo = LibGit2.GitRepo("/home/runner/.julia/dev/HelloWorldC_jll")
│   refspecs = 1-element Vector{String}: …
│   commit = GitHash("1fd43511160e4d2b7e02282ee7f69528a79029da")
│   remoteurl = "https://github.com/EnzymeAD/HelloWorldC_jll.jl.git"
└ @ BinaryBuilder ~/.julia/packages/BinaryBuilder/vpKHt/src/AutoBuild.jl:1776
ERROR: LoadError: GitError(Code:ERROR, Class:HTTP, unexpected http status code: 403)

The app has read/write contents access to EnzymeAD/HelloWorldC_jll.jl but the push is failing, I don't know what else to think of.

@giordano giordano force-pushed the mg/register branch 6 times, most recently from f912630 to 40d7b51 Compare November 8, 2025 00:43
giordano
giordano commented Nov 10, 2025
View reviewed changes
.github/workflows/build-reactant-reusable.yml Outdated
Comment on lines 20 to 25
default: 'R/Reactant'
default: 'H/HelloWorldC2'
Copy link
Member Author

@giordano giordano Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder we need to revert this at the end

giordano
giordano commented Nov 10, 2025
View reviewed changes
.github/workflows/build-reactant-reusable.yml Outdated
env:
GITHUB_TOKEN: ${{ steps.generate_token.outputs.token }}
JLBUILD_GITHUB_TOKEN: ${{ secrets.JLBUILD_GITHUB_TOKEN }}
JULIA_DEBUG: BinaryBuilder
Copy link
Member Author

@giordano giordano Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this debug

giordano
giordano commented Nov 10, 2025
View reviewed changes
R/Reactant/build_tarballs.jl Outdated
Comment on lines 674 to 676
if !Sys.islinux(platform) || gpu != "none" || mode != "opt"
continue
end
Copy link
Member Author

@giordano giordano Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And revert this as well

@giordano giordano changed the title Start preparing code for registration Enable registration Nov 10, 2025
@giordano giordano marked this pull request as ready for review November 10, 2025 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@giordano @wsmoses