Bubble trouble #635
Merged
Bubble trouble #635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is related to solvers having different counts of bubble DOFs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the handling of bubble DOFs
indices for bubble DOFs only when the solver has
"Bubbles In Global System = True" (the default) together with
(i) either an "Element" command leading to bubble DOFs
(ii) or the command "Bubbles = True".
In the case of "Bubbles = True" the count of bubble DOFs cannot be controlled in
a solverwise manner (the maximal count of available bubble indices is returned).
Otherwise the count of bubble DOFs is determined in a solverwise manner, so
for the best control of bubble DOFs it is recommended to use an Element command.
GetElementDOFs so that they are consistent with the handling of bubbles
explained in the first item.
A test case NaturalConvectionRestartCycle has suffered from having permutations
of wrong sizes and also needed a fix of norm.
In addition to these changes, this commit contains an unrelated fix for
BlockSolve to avoid processing outside array bounds.