Fix call to modify_gen_kwargs in vllm_vlms.py#3573
Merged
baberabb merged 2 commits intoEleutherAI:mainfrom Feb 11, 2026
Merged
Conversation
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
|
|
This was referenced Feb 10, 2026
Contributor
|
LGTM! Thanks for the PR |
baberabb
approved these changes
Feb 11, 2026
Contributor
Author
|
Thanks for the quick merge! If possible a patch release would be greatly appreciated. This PR was made as part of the effort to upgrade vLLM to Transformers v5. |
Contributor
Will try by friday, unless it's very urgent? also pushed #3582. The changes are mostly type fixes, but forgot to mention the |
Contributor
Author
|
Friday is good for me. I just want to make sure that we can bump |
Tracin
pushed a commit
to Tracin/lm-evaluation-harness
that referenced
this pull request
Mar 11, 2026
* Fix call to `modify_gen_kwargs` in `vllm_vlms.py` Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> * pacify pre-commit --------- Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Co-authored-by: Baber <baber@hey.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#3509 updated the return spec of
VLLM.modify_gen_kwargsto returntuple[dict, list[str], int]without updating a call location in theVLLM_VLM(VLLM)class.This PR updates the call location so that the last two elements of the
tupleare ignored.