feature(normalize gen_kwargs; add truncation_side to vllm)!#3509
Merged
feature(normalize gen_kwargs; add truncation_side to vllm)!#3509
truncation_side to vllm)!#3509Conversation
2961d03 to
4514256
Compare
# Conflicts: # lm_eval/models/vllm_causallms.py
truncation_side to vllm)!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #3505
do_sampleandtemperatureto be consistent across models.truncation_side=right|middle|leftarg to vllm to use other than left truncation. Will see about adding this to huggingface as well, but slightly non-trivial as HF requires sampling params per batch while vllm can run different per sample.closes #3505 where there was an inconsistency in sampling params between HF and vllm when both
do_sample: falseAND a non-zero temperature is specified in a task config. Now normalized to:temperature: 0.8(no do_sample)do_sample: falsedo_sample: false, temperature: 0.8do_sample: true, temperature: 0.8