Repository navigation
ci: finite census waits out the exit window before refusing a new child (flaky source-home-linux) - #1263
Merged
Conversation
added 2 commits
October 30, 2026 21:08
…ld (flaky source-home-linux) source-home-linux failed intermittently with 'finite journey live child identity is unavailable' (base run 41052807996 at cf24ae3, #1256 run 41059901772). It was green at 68c0116, at 995618d and on #1238's rerun. observe_once saw a new pid whose /proc/<pid>/exe was already gone (after exit_mm) while its flags=0 pidfd was not yet readable (before whole-group exit), and refused it. It now waits up to 250 ms on that pidfd, once; a pidfd that stays quiet still refuses exactly as before. Test: test_finite_census_waits_out_exit_race_and_still_refuses_a_quiet_pidfd (falsifier: revert the wait -> red). ci-release-policy-test.py 121 OK.
… (FINITE_OBSERVER_MESSAGES)
SashaMIT
marked this pull request as ready for review
October 30, 2026 15:56
SashaMIT
pushed a commit
that referenced
this pull request
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hardens a CI flake. It is not a merge blocker: source-home-linux was green at 68c0116, at 995618d and on #1238's rerun.
Failure: base run 41052807996 at cf24ae3 and #1256 run 41059901772:
installed Runtime exited before health (census: RuntimeError: finite journey live child identity is unavailable), raised at scripts/ci-installed-journeys.py:535.Cause:
observe_oncesaw a new pid (retained is None) whose/proc/<pid>/exehad already gone (after exit_mm), while its flags=0 pidfd was not yet readable (whole-group exit not yet signalled). It refused on a single poll(0).Change:
pidfd_exited(fd, timeout=250)makes one bounded poll.pidfd_exitedrefuses a non-int timeout or one outside 0..250.Test:
test_finite_census_waits_out_exit_race_and_still_refuses_a_quiet_pidfd, with subTests for a readable and a quiet pidfd.[(1100, 0)] != [(1100, 250)]).python3 scripts/ci-release-policy-test.py: Ran 121 tests, OK.Scope: scripts/ only, +55/-3.