Repository navigation
Conversation
added 2 commits
October 30, 2026 20:01
…-1228-f)
`cargo clippy --all-targets -- -D warnings` for lab/agent-conformance failed on
main. This is a behaviour-preserving lint cleanup:
- report.rs:100 collapses the duplicate-inventory if/else-if into one condition
(same short-circuit: an invalid name never inserts).
- report.rs:399 changes `!parse().is_ok()` to `parse().is_err()`.
- standin-runtime/mod.rs: `impl Default for StandIn` calling `new()`.
- tests/common/grants.rs:2857,3064,3094: `&[x.clone()]` becomes
`std::slice::from_ref(&x)`.
Clippy exits 0. standin_contract 13/0, standin_grants 1/0, fmt clean.
effects: 44 passed, 19 failed, 12 ignored. All 19 failures are the
darwin-only operator-Home prerequisite skip ("probe could not run" at
probe.rs:139). The three edited tests pass: cancel_refuses_retries_and_unexpected_requests,
kill_refuses_requests_from_any_session and kill_sibling_read_must_be_new_in_its_session.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes I-1228-f:
cargo clippy --all-targets -- -D warningsfor lab/agent-conformance failed on spike/agent-host. Lint cleanup only, with no change in behaviour. 3 files, +21/−8.src/report.rs:100: the duplicate-inventory if/else-if becomes one||condition. The short-circuit is the same: an invalid name never inserts.src/report.rs:399:!parse().is_ok()becomesparse().is_err().standin-runtime/mod.rs: addsimpl Default for StandIn, which callsnew().tests/common/grants.rs:2857,3064,3094:&[x.clone()]becomesstd::slice::from_ref(&x).Results (box, Linux):
--test effects: 44 passed, 19 failed, 12 ignored.cancel_refuses_retries_and_unexpected_requests,kill_refuses_requests_from_any_session,kill_sibling_read_must_be_new_in_its_session.No falsifier, because no guard was added or removed.