accept UrlParams.Input in some UrlParams apis - #2505
Merged
Conversation
🦋 Changeset detectedLatest commit: 6ab7cfd The changes in this PR will be included in the next version bump. This PR includes changesets to release 27 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
KhraksMamtsov
changed the title
KhraksMamtsov
changed the title
Duration module
tim-smart
requested changes
Jun 29, 2026
Contributor
Author
|
@tim-smart The behavior of baseUrl() isn't very intuitive. const baseUrl = (): string | undefined => {
if (
"location" in globalThis &&
globalThis.location !== undefined &&
globalThis.location.origin !== undefined &&
globalThis.location.pathname !== undefined
) {
return location.origin + location.pathname
}
return undefined
}
/**
* Creates a `URL` safely by appending `UrlParams` and an optional hash to a URL string.
*
* **Details**
*
* Returns a `Result` that fails with `UrlParamsError` if the URL cannot be
* constructed.
*
* @category converting
* @since 4.0.0
*/
export const makeUrl = (
url: string,
params: UrlParams,
hash: string | undefined
): Result.Result<URL, UrlParamsError> => {
try {
const urlInstance = new URL(url, baseUrl())
for (let i = 0; i < params.params.length; i++) {
const [key, value] = params.params[i]
if (value !== undefined) {
urlInstance.searchParams.append(key, value)
}
}
if (hash !== undefined) {
urlInstance.hash = hash
}
return Result.succeed(urlInstance)
} catch (e) {
return Result.fail(new UrlParamsError({ cause: e }))
}
} |
tim-smart
changed the title
Duration module
tim-smart
enabled auto-merge (squash)
July 1, 2026 21:39
Contributor
Bundle Size Analysis
|
tim-smart
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Description
Updated the Input type to include the target type, following the approach used in the
Durationmodule, to improve usability.Related