Strip response metadata from HTTP server span failures - #2454
Merged
tim-smart merged 3 commits intoJun 23, 2026
Conversation
🦋 Changeset detectedLatest commit: 928d9ad The changes in this PR will be included in the next version bump. This PR includes changesets to release 27 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Author
|
@tim-smart ptal thanks! |
tim-smart
approved these changes
Jun 23, 2026
tim-smart
enabled auto-merge (squash)
June 23, 2026 01:41
Contributor
Bundle Size Analysis
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a streamed HTTP response fails after its headers have been sent, the Node server keeps the original
HttpServerResponsein the failure cause. This lets the platform finish the request with the response that was already started.The HTTP tracer currently ends the server span with that full cause. OpenTelemetry can then pick the response as the span status message and render the whole object, including headers and body metadata, instead of showing the stream error. We hit this with an SSE endpoint: the request correctly had HTTP status 200, but its failed span displayed a serialized
HttpServerResponseas the error.Fix
Use
causeResponseStrippedwhen ending the HTTP server span as well as when reading response attributes. The response still supplies status and header attributes, while the span failure only contains the underlying application or stream error. If the response was the only cause entry, the span ends successfully.Test
The regression test models a stream failure after headers were sent and checks that: