This repository has been archived by the owner on Aug 7, 2024. It is now read-only.
Issue (No Space between add link and first link #9406 ) is Fixed. #9822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issue link #9406 |
|
@donishyar looks good👌 |
eddiejaoude
reviewed
Nov 23, 2023
components/account/manage/Edit.js
Outdated
| <a | ||
| href={href} | ||
| aria-label={`Edit ${label}`} | ||
| className="rounded-full bg-secondary-medium p-2 text-white shadow-sm hover:bg-tertiary-medium focus-visible:outline focus-visible:outline-2 focus-visible:outline-offset-2 focus-visible:outline-secondary-medium absolute top-0 left-0 pointer z-10" | ||
| className="rounded-full bg-secondary-medium p-2 text-white shadow-sm hover:bg-tertiary-medium focus-visible:outline focus-visible:outline-2 focus-visible:outline-offset-2 focus-visible:outline-secondary-medium absolute top-0 -left-4 pointer z-10" |
There was a problem hiding this comment.
how do these changes affect other places that use the Edit component?
eddiejaoude
reviewed
Nov 23, 2023
eddiejaoude
suggested changes
Nov 25, 2023
|
|
Yes, that is my point, did you test all other pages to make sure they still work after this change? |
|
|
@donishyar did you mean to close the PR? |
5 tasks
eddiejaoude
added a commit
that referenced
this pull request
Jan 12, 2024
* No Space between add link and first link #9406 * user links fixed with better way * revert changes * margin top added to edit icon and pencil icon size reduced * Update loftwah.json changes reverted --------- Co-authored-by: Eddie Jaoude <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue
Closes #9406
Changes proposed
Check List (Check all the applicable boxes)
Screenshots
Note to reviewers