Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

[BUG] No Space between add link and first link #9406

Closed
noobyco opened this issue Oct 7, 2023 · 32 comments · Fixed by #9943
Closed

[BUG] No Space between add link and first link #9406

noobyco opened this issue Oct 7, 2023 · 32 comments · Fixed by #9943
Assignees
Labels
🕹 aspect: interface undefined 🛠 goal: fix undefined good first issue undefined 🔢 points: 2 undefined 🏁 status: ready for dev You can asked for this issue to be assigned (if not already assigned)

Comments

@noobyco
Copy link
Contributor

noobyco commented Oct 7, 2023

Description

On the Links page page, The Edit button of the first link seems to touch the Add Link button. We just need a little padding between the div containing the Add Link, REORDER buttons and the first link created by the user. Refer to the screenshot for a better understanding :)

Screenshots

image

Do you want to work on this issue?

None

Additional information

No response

@noobyco noobyco added 🚦 status: awaiting triage Waiting for maintainers to verify (please do not start work on this yet) 🛠 goal: fix undefined labels Oct 7, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2023

To reduce notifications, issues are locked until they are 🏁 status: ready for dev You can asked for this issue to be assigned (if not already assigned) and to be assigned. You can learn more in our contributing guide https://github.com/EddieHubCommunity/BioDrop/blob/main/CONTRIBUTING.md

@github-actions github-actions bot locked and limited conversation to collaborators Oct 7, 2023
@eddiejaoude eddiejaoude added 🕹 aspect: interface undefined 🏁 status: ready for dev You can asked for this issue to be assigned (if not already assigned) 🔢 points: 2 undefined and removed 🚦 status: awaiting triage Waiting for maintainers to verify (please do not start work on this yet) labels Oct 15, 2023
@eddiejaoude
Copy link
Member

Great suggestion 👍

@github-actions github-actions bot unlocked this conversation Oct 15, 2023
@github-actions
Copy link
Contributor

The issue has been unlocked and is now ready for dev. If you would like to work on this issue, you can comment to have it assigned to you. You can learn more in our contributing guide https://github.com/EddieHubCommunity/BioDrop/blob/main/CONTRIBUTING.md

@eddiejaoude eddiejaoude added good first issue undefined Hacktoberfest Good issues for Hacktoberfest participants labels Oct 15, 2023
@ezhil56x
Copy link
Contributor

I would like to work on this. Please assign it to me 🙂

@Vijaykv5
Copy link
Member

Would love to work on it

@sadiq1402
Copy link

I would like to work on it

@Sumit21kumar
Copy link

Please assign to me

@eddiejaoude
Copy link
Member

eddiejaoude commented Oct 15, 2023

@ezhil56x you did ask first but you have already done a good first issue and we try to give good first issues to new people on the project

@Vijaykv5 as you asked next, I will assign the issue to you

@Vijaykv5
Copy link
Member

Thanks @eddiejaoude for assigning me :)

@ezhil56x
Copy link
Contributor

@eddiejaoude No problem will look to work on other issues 😄

@Vijaykv5
Copy link
Member

@eddiejaoude @ezhil56x May you could help me with the setup. I done it using docker but I'm not able to sign up with github locally

@Vijaykv5
Copy link
Member

Screenshot 2023-10-15 at 6 04 08 PM How to fix this error?

@noobyco
Copy link
Contributor Author

noobyco commented Oct 15, 2023

@eddiejaoude @ezhil56x May you could help me with the setup. I done it using docker but I'm not able to sign up with github locally

make sure to update your Env Variables GITHUB_ID, GITHUB_SECRET. Do refer https://www.biodrop.io/docs/environments/environment-variables. If you still get stuck after that, reach out to the discord server :)

@Koushik1311
Copy link

This issue has been open for quite some time I would like to work on this issue can you assign this to me?

@SaraJaoude
Copy link
Member

This issue has been open for quite some time I would like to work on this issue can you assign this to me?

@Koushik1311 I would suggest you familiarise yourself with this project's Contributing Guide - this issue was assigned three days ago and we only look to unassign issues when there has been no activity from the assignee for two weeks. Please consider this in future, especially as your comment puts unnecessary pressure on the assignee.

@Vijaykv5
Copy link
Member

I would make PR as soon as possible but I encountered into Errors

@Vijaykv5
Copy link
Member

Hey Done...Please check the PR @SaraJaoude @eddiejaoude

@eddiejaoude
Copy link
Member

Thank you @Vijaykv5 but you don't need to post a comment in the issue and also tag us, this generates a lot more noise for the project and maintainers, increasing our work and thus causing us to get to the pull requests more slowly - I appreciate your enthusiasm but you only raised the pull request a few minutes ago and we will get the notification from that. We are working through all notifications and will get to yours when we can

@Vijaykv5
Copy link
Member

Thank you @Vijaykv5 but you don't need to post a comment in the issue and also tag us, this generates a lot more noise for the project and maintainers, increasing our work and thus causing us to get to the pull requests more slowly - I appreciate your enthusiasm but you only raised the pull request a few minutes ago and we will get the notification from that. We are working through all notifications and will get to yours when we can

Sure! Sorry for the tag :)

@akash19coder
Copy link
Contributor

akash19coder commented Oct 25, 2023

Isn't this issue similar to the issue: #8824? I have found similarities between both issues as both issues deal with with alignment of EDIT BUTTON ICON in the manage links page.

@eddiejaoude
Copy link
Member

eddiejaoude commented Oct 25, 2023

Thanks @akash19coder for checking, but this issue is only about spacing between the action buttons and the list

ℹ️ eddiejaoude has some opened assigned issues: 🔧View assigned issues

@ScriptShah
Copy link
Contributor

I am new to open source i 'd like to contribute.

@eddiejaoude eddiejaoude assigned ScriptShah and unassigned Vijaykv5 Nov 18, 2023
@eddiejaoude
Copy link
Member

eddiejaoude commented Nov 18, 2023

@donishyar the issue was assigned, but as there was no activity for 2 weeks by the assignee, I have reassigned it to you

ℹ️ eddiejaoude has some opened assigned issues: 🔧View assigned issues

@SaraJaoude SaraJaoude removed the Hacktoberfest Good issues for Hacktoberfest participants label Nov 19, 2023
@VineeTagarwaL-code
Copy link

@eddiejaoude Hi sir , i have fixed the issue and right now i am sending a pr that solves the issue and also fixes one more bug in the UI of the same page

@eddiejaoude
Copy link
Member

eddiejaoude commented Nov 21, 2023

eddiejaoude Hi sir , i have fixed the issue and right now i am sending a pr that solves the issue and also fixes one more bug in the UI of the same page

The issue was assigned a few days ago to someone else, so I will be closing your pull request - please read our contributing guidelines to avoid causing confusion to the project and community, plus to reduce wasting your time, and also the maintainers time.

Please remember real world projects and open source are about collaboration not competition

@VineeTagarwaL-code
Copy link

Thank you sir , if no activity is found by assignee please assign this to me

@Rohithkumar77
Copy link

i can fix the issue

@SaraJaoude
Copy link
Member

i can fix the issue

@Rohithkumar77 this issue is being addressed by the assignee - there is already a Pull Request open for it. If you are looking to contribute to this project I would suggest reading our Contributing Guide first, so that you can see how we assign issues/how you can request them.

@eddiejaoude
Copy link
Member

eddiejaoude commented Dec 18, 2023

@donishyar please only add a margin to the specific item and also reference the issue in the Pull Request.

ℹ️ eddiejaoude has some opened assigned issues: 🔧View assigned issues

@ScriptShah
Copy link
Contributor

ScriptShah commented Dec 18, 2023

ok will do.

ℹ️ donishyar has some opened assigned issues: 🔧View assigned issues

@Rohit2968
Copy link

Please assign this issue to me. This will become my First Contribution.

@SaraJaoude
Copy link
Member

Please assign this issue to me. This will become my First Contribution.

@Rohit2968 before making your first contribution it is a good idea to look through the project's Contributing Guide, so that you can see the requirements and guidelines. We cannot assign this issue to you as it is assigned to someone else - in future you can check this at the top right of the page under the Assignees box, before making a comment.

eddiejaoude added a commit that referenced this issue Jan 12, 2024
* No Space between add link and first link #9406

* user links fixed with better way

* revert changes

* margin top added to edit icon and pencil icon size reduced

* Update loftwah.json

changes reverted

---------

Co-authored-by: Eddie Jaoude <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.