remove earthly token and fix ci #32
Conversation
…ns setup. TODO: switch to ECR public or google public mirror instead or just removing mirroring entirely?
…r than doc lint) that have run so far
…t-ci-working as the buildkitd image--unclear why. perhaps a sequencing logic issue where the CI builds attempt to use the previous binary and cannot handle a failure of the previous job? restore cache from to see if that is somehow related
… settings in the UI need adjustment
…e registry paths with dind repo terms
…g a single repository for now
…t intermediary img
* chore(earthbuild): fix +lint-all * chore: run Podman CI Ubuntu on any pull_request * remove unused verbose field * undo Podman CI Ubuntu workflow changes
Currently, the race-test image for a CI build step is generated the step before with the new EarthBuild name: ghcr.io/earthbuild/earthbuild:buildkitd-race-test. The next step references the original Earthly name: earthly/buildkitd:race-test. This causes a build failure. Update to the new name. Co-authored-by: Squirrel <[email protected]>
* feat: don't login to docker if not using docker
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @gilescope, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request implements a significant re-scoping of the project's features by systematically removing all explicit integrations and functionalities associated with Earthly Cloud services. This includes the deprecation of Earthly Satellites, Cloud Secrets, and OpenID Connect (OIDC) authentication. The changes simplify the codebase by eliminating the EARTHLY_TOKEN and a suite of earthly account, earthly org, and earthly secrets CLI commands, along with their underlying logic and documentation. The project now pivots towards a generic 'remote buildkit' approach for similar functionalities, indicating a strategic shift in product offerings or a rebranding under 'EarthBuild'.
Highlights
- Deprecation of Earthly Cloud Features: All explicit integrations and functionalities related to Earthly Cloud services, including Earthly Satellites, Cloud Secrets, and OpenID Connect (OIDC) authentication, have been removed from the codebase and documentation.
- Removal of Authentication Mechanisms: The
EARTHLY_TOKENenvironment variable, theearthly accountCLI commands (e.g., register, login, create-token), and theearthly orgCLI commands have been entirely removed, streamlining the project's authentication and account management. - Shift to Remote Buildkit: Documentation has been updated across multiple files to explicitly state that 'EarthBuild does not support Satellites' and directs users to utilize 'remote buildkit' as the alternative for similar functionalities.
- Codebase Simplification: Core code related to OIDC parsing, AWS credential provisioning with OIDC, and various feature flags for these functionalities have been removed, along with their associated Go module dependencies.
- Test Suite Reduction: A significant portion of the integration test suite, specifically tests for
earthly account,earthly secrets,earthly registry, and OIDC functionality, have been removed, reflecting the removal of these features.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
gilescope
changed the title
|
I'm happy with this PR now. |
kmannislands
left a comment
kmannislands
left a comment
There was a problem hiding this comment.
Good stuff. Shall I merge and we can fix the remaining failing job in a follow-up?
Removes CI associated with OIDC and earthly cloud secrets and fixes a bunch of CI jobs and removes cloud docs.
EDIT: TODO: don't rip out OIDC, just disable tests till we have a way to test it. (OIDC is under an experimental flag anyway)