chore: fix test misc jobs #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @janishorsts, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a chore to fix misc test jobs by streamlining the test suite configuration. It removes a specific test group (test-misc-group3) and an associated offline-test target, along with restructuring the remaining misc test groups within the Earthfile and the Buildkite execution script. This change likely resolves issues or redundancies in the existing test setup.
Highlights
- Test Suite Refinement: Removed
test-misc-group3from the Buildkite test execution script (.buildkite/tests.sh), indicating it's no longer part of the standardmisctest run in the CI/CD pipeline. - Test Target Removal: Eliminated the
offline-testtarget definition from theEarthfile, which previously ran Go tests with network access disabled. This also involved removing thetest-misc-group2target that depended on it. - Earthfile Test Restructuring: Reorganized the
test-misctarget inEarthfileby removing the now-defuncttest-misc-group3reference and promoting the formertest-misc-group3(which builtearthly-script-no-stdout) to become the newtest-misc-group2.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request refactors the miscellaneous test jobs by removing the offline-test and restructuring the test groups. While the restructuring seems reasonable, the removal of the offline test is a concern as it might reduce test coverage. I've also pointed out a minor inconsistency in target definitions for better maintainability.
gilescope
approved these changes
Jul 25, 2025
kmannislands
added a commit
that referenced
this pull request
Aug 6, 2025
* explore structure and dependencies of the initial CI build * remove dependency on private earthly mirror, move to earthbuild actions setup. TODO: switch to ECR public or google public mirror instead or just removing mirroring entirely? * fix +lint-docs * attempt to solve container registry issues blocking all CI jobs (other than doc lint) that have run so far * weird issue where earthly is using docker.io/earthly/buildkitd:dev-get-ci-working as the buildkitd image--unclear why. perhaps a sequencing logic issue where the CI builds attempt to use the previous binary and cannot handle a failure of the previous job? restore cache from to see if that is somehow related * figure out root of the wrong bootstrap image problem * try adding permissions to the github actions definition. TODO: see if settings in the UI need adjustment * move all SAVE IMAGE calls to ghcr for now, using a global variable * get another place that I missed with --DEFAULT_BUILDKITD_IMAGE * another place where implicit docker.io was missed 🤦 * try to fix stage-2 build * --wip-- try to get build post stage-2 working * add back mirror settting, switching to gcr mirror instead of earthly corp * apply giles/janis review feedback: align arg names used to build image registry paths with dind repo terms * resolve action lint issues by adding back workflow params for compatibility (for now) * try switching to env.GITHUB_TOKEN which claude believes to automatically be available * attempt to fix where we source the earthly binary from * fix reference format to the moved buildkitd image as well * comment out auto-skip for now since it requires earthly cloud to work * align actual image name with what the CI pipeline expects--still using a single repository for now * simple update, conmtinuing to use the main repos GHCR for the buildkit intermediary img * chore(earthbuild): fix +lint-all (#22) * chore(earthbuild): fix +lint-all * chore: run Podman CI Ubuntu on any pull_request * remove unused verbose field * undo Podman CI Ubuntu workflow changes * chore: fix docker-test-misc job (#26) * ci: update race-test image name (#25) Currently, the race-test image for a CI build step is generated the step before with the new EarthBuild name: ghcr.io/earthbuild/earthbuild:buildkitd-race-test. The next step references the original Earthly name: earthly/buildkitd:race-test. This causes a build failure. Update to the new name. Co-authored-by: Squirrel <[email protected]> * chore(earthbuild): fix docker-tests-no-qemu-group9 job in Docker CI Ubuntu (#29) * chore(earthbuild): fix +docker-tests-no-qemu-group4 (#27) * fix podman teardown (#30) * feat: don't login to docker if not using docker * fix examples1 (#31) * feat: don't login to docker if not using docker * fix: examples1/grpc example * chore(earthbuild): fix docker-test-misc-* jobs (#34) * chore: fix docker-earthly-image-test / earthly-image-tests (#53) --------- Co-authored-by: Janis Horsts <[email protected]> Co-authored-by: John Moon <[email protected]> Co-authored-by: Squirrel <[email protected]> Co-authored-by: Giles Cope <[email protected]>
kmannislands
added a commit
that referenced
this pull request
Aug 20, 2025
* explore structure and dependencies of the initial CI build * remove dependency on private earthly mirror, move to earthbuild actions setup. TODO: switch to ECR public or google public mirror instead or just removing mirroring entirely? * fix +lint-docs * attempt to solve container registry issues blocking all CI jobs (other than doc lint) that have run so far * weird issue where earthly is using docker.io/earthly/buildkitd:dev-get-ci-working as the buildkitd image--unclear why. perhaps a sequencing logic issue where the CI builds attempt to use the previous binary and cannot handle a failure of the previous job? restore cache from to see if that is somehow related * figure out root of the wrong bootstrap image problem * try adding permissions to the github actions definition. TODO: see if settings in the UI need adjustment * move all SAVE IMAGE calls to ghcr for now, using a global variable * get another place that I missed with --DEFAULT_BUILDKITD_IMAGE * another place where implicit docker.io was missed 🤦 * try to fix stage-2 build * --wip-- try to get build post stage-2 working * add back mirror settting, switching to gcr mirror instead of earthly corp * apply giles/janis review feedback: align arg names used to build image registry paths with dind repo terms * resolve action lint issues by adding back workflow params for compatibility (for now) * try switching to env.GITHUB_TOKEN which claude believes to automatically be available * attempt to fix where we source the earthly binary from * fix reference format to the moved buildkitd image as well * comment out auto-skip for now since it requires earthly cloud to work * align actual image name with what the CI pipeline expects--still using a single repository for now * simple update, conmtinuing to use the main repos GHCR for the buildkit intermediary img * chore(earthbuild): fix +lint-all (#22) * chore(earthbuild): fix +lint-all * chore: run Podman CI Ubuntu on any pull_request * remove unused verbose field * undo Podman CI Ubuntu workflow changes * chore: fix docker-test-misc job (#26) * ci: update race-test image name (#25) Currently, the race-test image for a CI build step is generated the step before with the new EarthBuild name: ghcr.io/earthbuild/earthbuild:buildkitd-race-test. The next step references the original Earthly name: earthly/buildkitd:race-test. This causes a build failure. Update to the new name. Co-authored-by: Squirrel <[email protected]> * chore(earthbuild): fix docker-tests-no-qemu-group9 job in Docker CI Ubuntu (#29) * chore(earthbuild): fix +docker-tests-no-qemu-group4 (#27) * fix podman teardown (#30) * feat: don't login to docker if not using docker * feat: OIDC not needed. Also remove EARTHLY_TOKEN * feat: remove secret integration * fix examples1 (#31) * feat: don't login to docker if not using docker * fix: examples1/grpc example * fix: make compile * feat: web test used earthly specific tech so we don't need to run it * feat: test not needed * fix: remove account login * fix: remove earthly cloud secret refs * fix: lint errors * fix: remove ref to earthly secret * fix: fix lint * fix: remove cloud test * fix: update docker2earth test * fix: analytics removed * fix: use EarthBuild cache * fix: point to EarthBuild image-test * fix: let's just delete the cloud docs * fix: restore some of aws-flag.earth * chore(earthbuild): fix docker-test-misc-* jobs (#34) * fix: go.sum not found * fix: restore oidc code * fix: stray fi from merge * fix: skip az test until we setup a login * fix: skip warn test * fix: skip aws test as no login * fix: skip gcp test as no login * putting back oidc bits * we intend to bring back this test * Cloud secrets will still be a thing. * Put back OIDC and cloud secret docs * Update docs/guides/best-practices.md * fix: trailing newlines * fix: ci * fix: debian stable v13 doesn't have software-properties-common --------- Co-authored-by: Kieran Mann <[email protected]> Co-authored-by: Janis Horsts <[email protected]> Co-authored-by: John Moon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docker-test-misc ✅