Skip to content

Conversation

@valeriupredoi
Copy link
Contributor

@valeriupredoi valeriupredoi commented Nov 17, 2025

Description

Reported in #4242 - need to re-align with the new type of config dir


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

@bouweandela
Copy link
Member

This doesn't seem to solve the issue for me. Could you try adding the test_upstream_development job to the commit workflow here?

workflows:
commit:
jobs:
- run_tests
- test_installation_from_source_test_mode
- test_installation_from_source_develop_mode

to see if it works in CI?

@valeriupredoi
Copy link
Contributor Author

it worked in GHA, let me pop it in Circle too

@valeriupredoi
Copy link
Contributor Author

test_upstream_development

ah it doesn't work no more after you merged the Concorde PR, bud - was working fine before - you fix it 😁

@bouweandela
Copy link
Member

The CMORizer tests check the log for certain messages. Since the log is now filtered, messages from the esmvaltool package were no longer included. Should be fixed by ESMValGroup/ESMValCore#2886.

@valeriupredoi
Copy link
Contributor Author

OK it's whack-a-mole time here:

  • matplotlib site is borked https://matplotlib.org/ so the docs are not able to fetch its inventory
  • the Circle dev test now fails (and so is the GHA similar test) with a Core problem:
>           raise RecipeError("\n".join(errors))
E           esmvalcore.exceptions.RecipeError: Unable to replace timerange=* by a value for Dataset:
E           {'dataset': 'EC-Earth3',
E            'project': 'CMIP6',
E            'mip': 'Amon',
E            'short_name': 'tas',
E            'ensemble': 'r1i1p1f1',
E            'exp': 'dcppA-hindcast',
E            'grid': 'gr',
E            'preprocessor': 'pptas',
E            'sub_experiment': 's1980',
E            'timerange': '*'}
E           supplementaries:
E             {'dataset': 'EC-Earth3',
E              'project': 'CMIP6',
E              'mip': '*',
E              'short_name': 'areacella',
E              'activity': '*',
E              'ensemble': '*',
E              'exp': '*',
E              'grid': 'gr',
E              'institute': '*',
E              'sub_experiment': 's1980',
E              'timerange': '*'}
E           session: 'test_20251118_122437'
E           Please check why the files:
E           test_0001-1849.nc with facets: {}
E           test_1850-9999.nc with facets: {}
E           do not provide the missing facet values. This will depend on the data source they come from, e.g. can they be extracted from the path for local files, or are they available from ESGF when when searching ESGF for files?

../ESMValCore/esmvalcore/_recipe/to_datasets.py:493: RecipeError

At least the WOA tests are passing 😬
@bouweandela you wanna merge this and tackle the timerange issue in a separate PR? 🍺

@valeriupredoi
Copy link
Contributor Author

nevermind, fixed all that in #4252

@bouweandela
Copy link
Member

Thanks V!

@bouweandela bouweandela merged commit 919430e into main Nov 21, 2025
1 of 6 checks passed
@bouweandela bouweandela deleted the fix_woa_cmorizer_tests branch November 21, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants