-
Notifications
You must be signed in to change notification settings - Fork 44
fix for thetao and so variables in BCC models #749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@koldunovn Could this be causing the problem with the BCC dataset in ESMValGroup/ESMValTool#1391? Anything that still needs to be done on this, or is it waiting for a review? |
|
@nielsdrost This fix is only for two ocean variables that I can personally check ( I would consider the PR ready, but you might want to expand it with atmospheric variables. On the other hand I would do one thing at a time, makes it easier to handle :) |
|
@koldunovn cheers mate, I think this one's good to go - but a test would be nice to have for the new functionality please 🍺 |
|
ping @koldunovn for a testy-test please 🍺 |
|
Will have a look at this after #1092 is merged. It can probably be fixed with Thetato = OceanFixGrid |
Before you start, please read our contribution guidelines.
Tasks
yamllintto check that your YAML files do not contain mistakesIf you need help with any of the tasks above, please do not hesitate to ask by commenting in the issue or pull request.
Closes #748