Skip to content

Conversation

@koldunovn
Copy link
Contributor

@koldunovn koldunovn commented Aug 18, 2020

Before you start, please read our contribution guidelines.

Tasks

  • Create an issue to discuss what you are going to do, if you haven't done so already (and add the link at the bottom)
  • This pull request has a descriptive title that can be used in a changelog
  • Add unit tests
  • Public functions should have a numpy-style docstring so they appear properly in the API documentation. For all other functions a one line docstring is sufficient.
  • If writing a new/modified preprocessor function, please update the documentation
  • Circle/CI tests pass. Status can be seen below your pull request. If the tests are failing, click the link to find out why.
  • Codacy code quality checks pass. Status can be seen below your pull request. If there is an error, click the link to find out why. If you suspect Codacy may be wrong, please ask by commenting.
  • Please use yamllint to check that your YAML files do not contain mistakes
  • If you make backward incompatible changes to the recipe format, make a new pull request in the ESMValTool repository and add the link below

If you need help with any of the tasks above, please do not hesitate to ask by commenting in the issue or pull request.


Closes #748

@koldunovn koldunovn requested review from schlunma and zklaus August 18, 2020 15:27
@nielsdrost
Copy link
Member

@koldunovn Could this be causing the problem with the BCC dataset in ESMValGroup/ESMValTool#1391?

Anything that still needs to be done on this, or is it waiting for a review?

@koldunovn
Copy link
Contributor Author

@nielsdrost This fix is only for two ocean variables that I can personally check (so and thetao). Looks like the problems @ValerioLembo having are for atmospheric variables (sorry, did not go through all conversation, it's super long now :))).

I would consider the PR ready, but you might want to expand it with atmospheric variables. On the other hand I would do one thing at a time, makes it easier to handle :)

@koldunovn koldunovn requested a review from jvegreg as a code owner February 4, 2021 12:27
@valeriupredoi
Copy link
Contributor

@koldunovn cheers mate, I think this one's good to go - but a test would be nice to have for the new functionality please 🍺

@valeriupredoi
Copy link
Contributor

ping @koldunovn for a testy-test please 🍺

@schlunma schlunma modified the milestones: IPCC AR6, v2.3.0 May 4, 2021
@schlunma
Copy link
Contributor

schlunma commented May 4, 2021

Will have a look at this after #1092 is merged. It can probably be fixed with

Thetato = OceanFixGrid

@zklaus zklaus modified the milestones: v2.3.0, v2.4.0 Jun 7, 2021
@zklaus
Copy link

zklaus commented Sep 14, 2021

I believe this has meanwhile been addressed in #1090 and #1092.

@zklaus zklaus closed this Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix for dataset Related to dataset-specific fix files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Thetao and so in BCC models

7 participants