-
Notifications
You must be signed in to change notification settings - Fork 44
Fix erroneous use of grid_latitude and grid_longitude and cleaned ocean grid fixes
#1092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
zklaus
requested changes
Apr 30, 2021
zklaus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really love the approach of unifying all these fixes! 👍 I have added some suggestions for the actual fix. Let me know what you think.
9 tasks
zklaus
approved these changes
May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
grid_latitudeandgrid_longitudetocell index along first/second dimension(see Erroneous use ofgrid_latitudeandgrid_longitude#1067).tosandsiconcof FGOALS-g3.I checked all affected preprocessed files (raw and regridded to a regular grid) before and after this PR with
cdo diffand found no differences.I didn't find any appearance of
grid_latitudeorgrid_longitudein ESMValTool, so this shouldn't affect any diagnostic.Closes #1067.
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: