Skip to content

Conversation

@schlunma
Copy link
Contributor

@schlunma schlunma commented Apr 29, 2021

This PR

I checked all affected preprocessed files (raw and regridded to a regular grid) before and after this PR with cdo diff and found no differences.

I didn't find any appearance of grid_latitude or grid_longitude in ESMValTool, so this shouldn't affect any diagnostic.

Closes #1067.


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@schlunma schlunma added fix for dataset Related to dataset-specific fix files cmor Related to the CMOR standard labels Apr 29, 2021
@schlunma schlunma requested a review from zklaus April 29, 2021 10:18
@schlunma schlunma requested a review from jvegreg as a code owner April 29, 2021 10:18
@schlunma schlunma self-assigned this Apr 29, 2021
Copy link

@zklaus zklaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really love the approach of unifying all these fixes! 👍 I have added some suggestions for the actual fix. Let me know what you think.

@schlunma schlunma added this to the v2.3.0 milestone May 4, 2021
@schlunma schlunma merged commit 66dd7bd into master May 5, 2021
@schlunma schlunma deleted the fix_ocean_grid_fix branch May 5, 2021 15:12
@bouweandela bouweandela mentioned this pull request Jun 27, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cmor Related to the CMOR standard fix for dataset Related to dataset-specific fix files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Erroneous use of grid_latitude and grid_longitude

3 participants