Skip to content

Fix a bug where the mask_fillvalues preprocessor only recorded provenance for the first result #2904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
valeriupredoi merged 1 commit into from
Nov 21, 2025
Merged

Fix a bug where the mask_fillvalues preprocessor only recorded provenance for the first result #2904

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions esmvalcore/preprocessor/_mask.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -688,18 +688,18 @@ def mask_fillvalues(
combined_mask,
)

input_products = {p.copy_provenance() for p in products}
for product in products:
for cube in product.cubes:
array = cube.core_data()
data = array_module.ma.getdata(array)
mask = array_module.ma.getmaskarray(array) | combined_mask
cube.data = array_module.ma.masked_array(data, mask)

# Record provenance
input_products = {p.copy_provenance() for p in products}
for other in input_products:
if other.filename != product.filename:
product.wasderivedfrom(other)
# Record provenance
for other in input_products:
if other.filename != product.filename:
product.wasderivedfrom(other)

return products

Expand Down