Skip to content

Conversation

@bouweandela
Copy link
Member

@bouweandela bouweandela commented Nov 21, 2025

Description

Fix a bug where the mask_fillvalues preprocessor only recorded provenance for the first result. This was introduced in #2340.


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@bouweandela bouweandela added bug Something isn't working preprocessor Related to the preprocessor labels Nov 21, 2025
@codecov
Copy link

codecov bot commented Nov 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.63%. Comparing base (8de26a5) to head (d98849c).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2904   +/-   ##
=======================================
  Coverage   95.63%   95.63%           
=======================================
  Files         263      263           
  Lines       15492    15492           
=======================================
  Hits        14816    14816           
  Misses        676      676           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bouweandela bouweandela marked this pull request as ready for review November 21, 2025 11:07
@bouweandela bouweandela added this to the v2.14.0 milestone Nov 21, 2025
Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch 🐛

@valeriupredoi valeriupredoi merged commit e9c30c9 into main Nov 21, 2025
4 checks passed
@valeriupredoi valeriupredoi deleted the fix-mask-fillvalues-provenance branch November 21, 2025 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working preprocessor Related to the preprocessor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants