-
Notifications
You must be signed in to change notification settings - Fork 44
Updated ICON doc with information on usage of extract_levels preprocessor #1903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1903 +/- ##
=======================================
Coverage 92.03% 92.03%
=======================================
Files 234 234
Lines 12042 12042
=======================================
Hits 11083 11083
Misses 959 959 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
axel-lauer
approved these changes
Jan 23, 2023
Contributor
axel-lauer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this to the documentation.
Co-authored-by: Axel Lauer <axel.lauer@dlr.de>
zklaus
pushed a commit
to zklaus/ESMValCore
that referenced
this pull request
Apr 13, 2023
<!--
Thank you for contributing to our project!
Please do not delete this text completely, but read the text below and
keep
items that seem relevant. If in doubt, just keep everything and add your
own text at the top, a reviewer will update the checklist for you.
-->
## Description
<!--
Please describe your changes here, especially focusing on why this pull
request makes ESMValCore better and what problem it solves.
Before you start, please read our contribution guidelines:
https://docs.esmvaltool.org/projects/ESMValCore/en/latest/contributing.html
Please fill in the GitHub issue that is closed by this pull request,
e.g. Closes ESMValGroup#1903
-->
This PR allows to compute the sea ice extent as a derived variable in
order to reduce the amount of saved data during the preprocessing
Closes ESMValGroup#1693
Link to documentation:
***
## [Before you get
started](https://docs.esmvaltool.org/projects/ESMValCore/en/latest/contributing.html#getting-started)
- [x] [☝ Create an
issue](https://github.com/ESMValGroup/ESMValCore/issues) to discuss what
you are going to do
##
[Checklist](https://docs.esmvaltool.org/projects/ESMValCore/en/latest/contributing.html#checklist-for-pull-requests)
It is the responsibility of the author to make sure the pull request is
ready to review. The icons indicate whether the item will be subject to
the [🛠 Technical][1] or [🧪 Scientific][2] review.
<!-- The next two lines turn the 🛠 and 🧪 below into hyperlinks -->
[1]:
https://docs.esmvaltool.org/en/latest/community/review.html#technical-review
[2]:
https://docs.esmvaltool.org/en/latest/community/review.html#scientific-review
- [x] [🧪][2] The new functionality is [relevant and scientifically
sound](https://docs.esmvaltool.org/projects/ESMValCore/en/latest/contributing.html#scientific-relevance)
- [x] [🛠][1] This pull request has a [descriptive title and
labels](https://docs.esmvaltool.org/projects/ESMValCore/en/latest/contributing.html#pull-request-title-and-label)
- [x] [🛠][1] Code is written according to the [code quality
guidelines](https://docs.esmvaltool.org/projects/ESMValCore/en/latest/contributing.html#code-quality)
~- [ ] [🧪][2] and [🛠][1]
[Documentation](https://docs.esmvaltool.org/projects/ESMValCore/en/latest/contributing.html#documentation)
is available~
- [x] [🛠][1] [Unit
tests](https://docs.esmvaltool.org/projects/ESMValCore/en/latest/contributing.html#tests)
have been added
- [x] [🛠][1] Changes are [backward
compatible](https://docs.esmvaltool.org/projects/ESMValCore/en/latest/contributing.html#backward-compatibility)
~- [ ] [🛠][1] Any changed [dependencies have been added or
removed](https://docs.esmvaltool.org/projects/ESMValCore/en/latest/contributing.html#dependencies)
correctly~
- [x] [🛠][1] The [list of
authors](https://docs.esmvaltool.org/projects/ESMValCore/en/latest/contributing.html#list-of-authors)
is up to date
- [x] [🛠][1] All [checks below this pull
request](https://docs.esmvaltool.org/projects/ESMValCore/en/latest/contributing.html#pull-request-checks)
were successful
***
To help with the number pull requests:
- 🙏 We kindly ask you to
[review](https://docs.esmvaltool.org/en/latest/community/review.html#review-of-pull-requests)
two other [open pull
requests](https://github.com/ESMValGroup/ESMValCore/pulls) in this
repository
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a description how to use the
extract_levelspreprocessor on native ICON data.Related to ESMValGroup/ESMValTool#3016 (comment)
Link to documentation: https://esmvaltool--1903.org.readthedocs.build/projects/ESMValCore/en/1903/quickstart/find_data.html#icon
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: