Skip to content

Conversation

@schlunma
Copy link
Contributor

@schlunma schlunma commented Jan 23, 2023

Description

Add a description how to use the extract_levels preprocessor on native ICON data.

Related to ESMValGroup/ESMValTool#3016 (comment)

Link to documentation: https://esmvaltool--1903.org.readthedocs.build/projects/ESMValCore/en/1903/quickstart/find_data.html#icon


Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@schlunma schlunma added the documentation Improvements or additions to documentation label Jan 23, 2023
@schlunma schlunma added this to the v2.8.0 milestone Jan 23, 2023
@schlunma schlunma requested a review from axel-lauer January 23, 2023 11:58
@schlunma schlunma self-assigned this Jan 23, 2023
@codecov
Copy link

codecov bot commented Jan 23, 2023

Codecov Report

Merging #1903 (1ba6f22) into main (12ff527) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1903   +/-   ##
=======================================
  Coverage   92.03%   92.03%           
=======================================
  Files         234      234           
  Lines       12042    12042           
=======================================
  Hits        11083    11083           
  Misses        959      959           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@axel-lauer axel-lauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this to the documentation.

schlunma and others added 2 commits January 23, 2023 15:07
Co-authored-by: Axel Lauer <axel.lauer@dlr.de>
@schlunma schlunma merged commit 25e508a into main Jan 23, 2023
@schlunma schlunma deleted the update_icon_doc branch January 23, 2023 15:19
zklaus pushed a commit to zklaus/ESMValCore that referenced this pull request Apr 13, 2023
<!--
    Thank you for contributing to our project!

Please do not delete this text completely, but read the text below and
keep
items that seem relevant. If in doubt, just keep everything and add your
    own text at the top, a reviewer will update the checklist for you.

-->

## Description

<!--
Please describe your changes here, especially focusing on why this pull
    request makes ESMValCore better and what problem it solves.

Before you start, please read our contribution guidelines:
https://docs.esmvaltool.org/projects/ESMValCore/en/latest/contributing.html

    Please fill in the GitHub issue that is closed by this pull request,
    e.g. Closes ESMValGroup#1903
-->
This PR allows to compute the sea ice extent as a derived variable in
order to reduce the amount of saved data during the preprocessing
Closes ESMValGroup#1693 

Link to documentation:

***

## [Before you get
started](https://docs.esmvaltool.org/projects/ESMValCore/en/latest/contributing.html#getting-started)

- [x] [☝ Create an
issue](https://github.com/ESMValGroup/ESMValCore/issues) to discuss what
you are going to do

##
[Checklist](https://docs.esmvaltool.org/projects/ESMValCore/en/latest/contributing.html#checklist-for-pull-requests)

It is the responsibility of the author to make sure the pull request is
ready to review. The icons indicate whether the item will be subject to
the [🛠 Technical][1] or [🧪 Scientific][2] review.

<!-- The next two lines turn the 🛠 and 🧪 below into hyperlinks -->
[1]:
https://docs.esmvaltool.org/en/latest/community/review.html#technical-review
[2]:
https://docs.esmvaltool.org/en/latest/community/review.html#scientific-review

- [x] [🧪][2] The new functionality is [relevant and scientifically
sound](https://docs.esmvaltool.org/projects/ESMValCore/en/latest/contributing.html#scientific-relevance)
- [x] [🛠][1] This pull request has a [descriptive title and
labels](https://docs.esmvaltool.org/projects/ESMValCore/en/latest/contributing.html#pull-request-title-and-label)
- [x] [🛠][1] Code is written according to the [code quality
guidelines](https://docs.esmvaltool.org/projects/ESMValCore/en/latest/contributing.html#code-quality)
~- [ ] [🧪][2] and [🛠][1]
[Documentation](https://docs.esmvaltool.org/projects/ESMValCore/en/latest/contributing.html#documentation)
is available~
- [x] [🛠][1] [Unit
tests](https://docs.esmvaltool.org/projects/ESMValCore/en/latest/contributing.html#tests)
have been added
- [x] [🛠][1] Changes are [backward
compatible](https://docs.esmvaltool.org/projects/ESMValCore/en/latest/contributing.html#backward-compatibility)
~- [ ] [🛠][1] Any changed [dependencies have been added or
removed](https://docs.esmvaltool.org/projects/ESMValCore/en/latest/contributing.html#dependencies)
correctly~
- [x] [🛠][1] The [list of
authors](https://docs.esmvaltool.org/projects/ESMValCore/en/latest/contributing.html#list-of-authors)
is up to date
- [x] [🛠][1] All [checks below this pull
request](https://docs.esmvaltool.org/projects/ESMValCore/en/latest/contributing.html#pull-request-checks)
were successful

***

To help with the number pull requests:

- 🙏 We kindly ask you to
[review](https://docs.esmvaltool.org/en/latest/community/review.html#review-of-pull-requests)
two other [open pull
requests](https://github.com/ESMValGroup/ESMValCore/pulls) in this
repository
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants