Skip to content

Merge b4bdev 20250807#3395

Merged
slevis-lmwg merged 9 commits into
ESCOMP:masterfrom
slevis-lmwg:merge-b4bdev-20250807
Aug 8, 2025
Merged

Merge b4bdev 20250807#3395
slevis-lmwg merged 9 commits into
ESCOMP:masterfrom
slevis-lmwg:merge-b4bdev-20250807

Conversation

@slevis-lmwg
Copy link
Copy Markdown
Contributor

@slevis-lmwg slevis-lmwg commented Aug 7, 2025

Description of changes

#3352 Add Fang Li's abm and popden .ncl scripts to /tools/contrib

While in #3395, I'm also adding a critical reminder about izumi baseline in README.CHECKLIST.master_tags:
"When izumi’s baseline is ready, manually open read permissions to all."

Specific notes

CTSM Issues Fixed (include github issue #):
Addresses part of #2701

Are answers expected to change (and if so in what way)?
No

slevis-lmwg and others added 6 commits July 24, 2025 18:34
Merge b4b-dev to master

Implement namelist options for soil moisture activation factor used in MEGAN isoprene emissions.

Adds a GitHub issue template for things related to documentation.

Fixes a self-test.

Adds a broadcast of the namelist value for a few mapalgo items after reading it in so it is consistent across all ranks when not using the default value. Also update the mapalgo options list to be consistent with the NUOPC options, the MCT list was in place before this.

Update submodules so we are using the latest in cesm development for cesm3_0_alpha07b.

Harden github actions to improve security (use a hash, rather than a tag, reduce permissions to readonly when possible)

Update SpinupStability scripts for h0->h0a transition (backwards compatible).
Update run_clm_historical script for nuopc, extension through 2023, produces restart files for 1979 and 2000, and h0->h0a transition (backwards compatible).

Remove flexCN_FUN_BNF test and testmods as redundant

Fix string replacements in lreprstruct test:
The previous logic caused problems if "GRAIN" appeared in two (or more) strings, where one was a substring of the other. For example, in LREPRSTRUCT_Ly1_P128x1.f10_f10_mg37.I1850Clm50BgcCrop.derecho_gnu.clm-ciso--clm-cropMonthOutput, before this replacement, one line contained 'GRAINN_TO_FOOD' and a later line contained (among other things) "'GRAINN_TO_FOOD_PERHARV', 'GRAINN_TO_FOOD_ANN'". This was problematic because the first replacement of GRAINN_TO_FOOD incorrectly led to replacements in the later strings as well.
Add Fang Li's abm and popden .ncl scripts to /tools/contrib
@slevis-lmwg
Copy link
Copy Markdown
Contributor Author

slevis-lmwg commented Aug 7, 2025

./run_sys_tests -s aux_clm -c ctsm5.3.065 -g ctsm5.3.066 IN PROGRESS

  • derecho
  • izumi

@slevis-lmwg slevis-lmwg requested a review from ekluzek August 7, 2025 20:22
@slevis-lmwg
Copy link
Copy Markdown
Contributor Author

@ekluzek
testing will take a while to complete (izumi just started and derecho is slow), BUT I didn't really have to run testing when you look at this PR's code changes. So I have asked for your review/approval, so that I have it when the testing completes.

@ekluzek
Copy link
Copy Markdown
Contributor

ekluzek commented Aug 7, 2025

@slevis-lmwg I suppose it isn't bad to do the testing, but as you point out it doesn't really have to be done here. We would want to have a softlink for the baselines in place though. And I suppose it isn't bad to just run them to have them in place, that's actually pretty simple to do as well.

@slevis-lmwg
Copy link
Copy Markdown
Contributor Author

Testing on izumi finished with two failures that I think I can ignore, but pls tell me if I should not:

FAIL ERI_D_Ld9_P48x1.f10_f10_mg37.I2000Clm50Sp.izumi_nag.clm-reduceOutput--clm-nofireemis BASELINE ctsm5.3.065: ERROR CPRNC failed to open files
FAIL SMS_D_Ld5.f10_f10_mg37.I2000Clm50BgcCrop.izumi_nag.clm-irrig_alternate BASELINE ctsm5.3.065: ERROR CPRNC failed to open files

Testing on derecho is incredibly slow as others have been experiencing. If it's not done by morning, I will proceed with plan B and make a softlink to the previous baseline.

@ekluzek
Copy link
Copy Markdown
Contributor

ekluzek commented Aug 8, 2025

Hmmm. That's not something that you often see as an error. It could be a glitch with cprnc for those files as a random thing. But it could also indicate that there's something wrong with the files. So I would suggest resubmitting a few times to see if it persists or if it resolves by just running again. If it persists it could indicate a problem. But since the code really didn't change from the previous tag it can't be a problem with the code either.

So hopefully just resubmitting clears it up....

@slevis-lmwg
Copy link
Copy Markdown
Contributor Author

Good news. Resubmitting resolved the izumi failures.

@slevis-lmwg slevis-lmwg merged commit 9c390a0 into ESCOMP:master Aug 8, 2025
6 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in LMWG: Sprint Planning Board Aug 8, 2025
@slevis-lmwg slevis-lmwg deleted the merge-b4bdev-20250807 branch August 8, 2025 15:28
slevis-lmwg added a commit to slevis-lmwg/ctsm that referenced this pull request Aug 8, 2025
Merge b4b-dev to master

Adds Fang Li's abm and popden .ncl scripts to /tools/contrib (ESCOMP#3352)
and adds a reminder about izumi's baseline in README.CHECKLIST.master_tags:
"When izumi’s baseline is ready, manually open read permissions to all."

PR ESCOMP#3395
samsrabin added a commit that referenced this pull request Aug 8, 2025
Merge b4b-dev to master

Adds Fang Li's abm and popden .ncl scripts to /tools/contrib (#3352)
and adds a reminder about izumi's baseline in README.CHECKLIST.master_tags:
"When izumi’s baseline is ready, manually open read permissions to all."

PR #3395
slevis-lmwg added a commit to slevis-lmwg/ctsm that referenced this pull request Aug 11, 2025
Merge b4b-dev to master

Adds Fang Li's abm and popden .ncl scripts to /tools/contrib (ESCOMP#3352)
and adds a reminder about izumi's baseline in README.CHECKLIST.master_tags:
"When izumi’s baseline is ready, manually open read permissions to all."

PR ESCOMP#3395
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

b4b bit-for-bit

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants