UFS-specific modifications#411
Merged
Merged
Conversation
* account for taux,y sign change from atm * remove custom merge related solely to need to change sign * change sign for faxa_sen to match ATM export * use evap from atm directly
* flux_albav moved to _init * use_nextswcday for using clock instead of scalar field * min_albedo for setting min albedo used max(min_albedo,....) * giving a min_albedo value sets logical use_min_albedo, otherwise false and min_albedo=0 * set mean albdif and albdir via config. If not present, defaults to current values
* clean up ufs fields exchange by consolidating logical blocks * remove extraneous trim on fldname variables * remove conditionals on mediator fields
jedwards4b
approved these changes
Oct 8, 2023
mvertens
approved these changes
Oct 9, 2023
uturuncoglu
approved these changes
Oct 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Includes changes recently committed to https://github.com/NOAA-EMC/CMEPS
Specific notes
The SR
med_phases_prep_ocn_custom_nemsis removed because of the following changes:The module
esmFldsExchange_nemshas been refactored to be more concise and generic.Unnecessary
coupling_modeconditionals were removed where possibleContributors other than yourself, if any:
CMEPS Issues Fixed (include github issue #):
Are changes expected to change answers? (specify if bfb, different at roundoff, more substantial)
Any User Interface Changes (namelist or namelist defaults changes)?
Testing performed
Changes have been tested and committed in UFS.