-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for new getData([]) #48
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good Job so far Hugo. I'll do another review once you are ready to merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool!
Codecov Report
@@ Coverage Diff @@
## main #48 +/- ##
==========================================
+ Coverage 80.04% 84.27% +4.22%
==========================================
Files 8 8
Lines 406 477 +71
Branches 88 100 +12
==========================================
+ Hits 325 402 +77
+ Misses 44 35 -9
- Partials 37 40 +3
Continue to review full report at Codecov.
|
Closes #44
What kind of change does this PR introduce (bug fix, feature, docs update, ...)?
Add support for new ERC725 getData. See issue above for details.
What is the current behaviour (you can also link to an open issue here)?
Does't support getData() with array version (
bytes[]
andbytes32[]
)What is the new behaviour (if this is a feature change)?
Now, supports getData() with array version (
bytes[]
andbytes32[]
)! Does not support GraphQL provider !
It doesn't support "1 call" for multiple data yet
The work in this PR was already too big to handle this feature. I opened a ticket for this optimisation step:
#49
TODO: