Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use only one RPC call for getAllData() #49

Closed
Hugoo opened this issue Oct 30, 2021 · 0 comments · Fixed by #67
Closed

Use only one RPC call for getAllData() #49

Hugoo opened this issue Oct 30, 2021 · 0 comments · Fixed by #67
Assignees
@Hugoo
Labels
enhancement New feature or request

Comments

@Hugoo
Copy link
Contributor

Hugoo commented Oct 30, 2021

Summary

If lib wants to request multiple data keys: A,B, C
it will perform multiple: getData() calls:

  • For legacy: getData(A), getData(B), getData(C)
  • For new: getData([A]), getData([B]), getData([C])

It should instead send only one request:

  • For legacy: getDataMultiple([A, B, C])
  • For new: getData([A, B, C])
@Hugoo Hugoo mentioned this issue Oct 30, 2021
Merged
2 tasks
@Hugoo Hugoo added the enhancement New feature or request label Nov 23, 2021
@Hugoo Hugoo self-assigned this Nov 23, 2021
@Hugoo Hugoo mentioned this issue Nov 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Hugoo Hugoo

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

perf: use one RPC call on getData multiple ERC725Alliance/erc725.js
1 participant
@Hugoo