-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to load external particle fields from file #4997
Merged
RemiLehe
merged 33 commits into
ECP-WarpX:development
from
oshapoval:fix_ci_in_ext_particle_from_file
Jul 9, 2024
Merged
Add ability to load external particle fields from file #4997
RemiLehe
merged 33 commits into
ECP-WarpX:development
from
oshapoval:fix_ci_in_ext_particle_from_file
Jul 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wise copy Efield_fp.
…particle_from_file
…particle_from_file
It would be good to include the divergence cleaning from #4944 to these particle fields as well. |
RemiLehe
reviewed
Jun 24, 2024
4 tasks
ad9df06
to
1bcf7b6
Compare
RemiLehe
reviewed
Jul 9, 2024
RemiLehe
reviewed
Jul 9, 2024
RemiLehe
approved these changes
Jul 9, 2024
RemiLehe
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR #4981 @RemiLehe:
We currently have the ability to load an external grid field from a file (thanks to #3584).
This PR provides a similar ability for the external particle fields.
The external grid and particle fields differ e.g. in the case of the EM solver:
In this PR, support for external particle fields is achieved by reusing many of the structures that are used for the external grid fields. For instance, we store the fields from file into the field
Efield_fp_external
andBfield_fp_external
in both cases. (As a result, using external particle fields and external grid fields from file at the same time is not possible.) However:Efield_external
is added to the grid fieldsEfield_fp
directly.Efield_external
is instead added to the fields from which the particle gatherEfield_aux
. In some case (e.g. energy-conserving gather),Efield_fp
andEfield_aux
used to be aliases of each other. This is no longer the case if the external particle fields from file are used.