[WIP] Add ability to load external particle fields from file #4981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RemiLehe
changed the title
RemiLehe
force-pushed
the
ext_particle_from_file
branch
from
a8cf667
to
fd28932
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // TODO reuse WarpX::AddExternalFields | ||
| // TODO replace fp_external with simply external | ||
| for (int lev = 0; lev <= finest_level; ++lev) { | ||
| // FIXME: RZ multimode has more than one component for all these |
Check notice
Code scanning / CodeQL
FIXME comment Note
RemiLehe
commented
Jun 12, 2024
| const amrex::IntVect& ng_src = guard_cells.ng_FieldGather; | ||
|
|
||
| // Level 0: Copy from fine to aux | ||
| // TODO Check if aux and fp are aliases of each other. If so, we can skip the copy. |
There was a problem hiding this comment.
Not needed anymore after this PR is merged:
AMReX-Codes/amrex#3986
RemiLehe
commented
Jun 17, 2024
| MultiFab::Copy(*Efield_aux[0][2], *Efield_fp[0][2], 0, 0, Efield_aux[0][2]->nComp(), ng_src); | ||
| MultiFab::Copy(*Bfield_aux[0][0], *Bfield_fp[0][0], 0, 0, Bfield_aux[0][0]->nComp(), ng_src); | ||
| MultiFab::Copy(*Bfield_aux[0][1], *Bfield_fp[0][1], 0, 0, Bfield_aux[0][1]->nComp(), ng_src); | ||
| MultiFab::Copy(*Bfield_aux[0][2], *Bfield_fp[0][2], 0, 0, Bfield_aux[0][2]->nComp(), ng_src); |
There was a problem hiding this comment.
Here, we need to check whether WarpX::fft_do_time_averaging is true. If yes,
MultiFab::Copy(*Bfield_aux[0][0], *Bfield_avg_fp[0][0], 0, 0, Bfield_aux[0][0]->nComp(), ng_src);
and otherwise, keep this code
|
Super-seeded by #4997 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently have the ability to load an external grid field from a file (thanks to #3584).
This PR provide a similar ability for the external particle fields.
The external grid and particle fields differ e.g. in the case of the EM solver:
t=0and serve as initial condition to the Maxwell solver.TODO:
aux. This means that this will automatically work with all other modules that gather the fields: particle push, ionization routine, etc.