Support WebP images on iOS 12 #386
Conversation
Should fix #385 fix #298 I tested this in Debug and Release builds with my own app via local images i.e. ```js <FastImage source={require("../assets/myImage.webp")} /> ``` Seems to work without any trouble. Since we are aiming for fast image lib, I think `SDWebImage/WebP` is a good candidate to be included with CocoaPod file?
|
I think this is related PR #387 |
|
Would this support those who use |
|
@jjgp I'm not sure but I think #386 (comment) addresses |
|
I believe you're correct I will follow up there! |
|
@jjgp will it be possible to merge this CocoaPod fix, or are you guys planning to merge them both at the same time once ready? |
|
@iljadaderko I'm not a maintainer, however, am eager to get this fix as well. I don't see a problem with them being separate PRs. They should be merged into the same tagged release. Only comment I have is that we may want to assert (or at least test for now) that the pod version of SDWebImage is the same(ish) version as the vendor submodule in the other PR. |
|
It's merged! Sorry, there was another PR open for this and I merged that one. Thank you though @iljadaderko ! https://github.com/DylanVann/react-native-fast-image/releases/tag/v5.1.3 |
Should
fix #385
fix #298
I tested this in Debug and Release builds with my own app (ios 12) via local images i.e.
Seems to work without any trouble. Since we are aiming for fast image lib, I think
SDWebImage/WebPis a good candidate to be included with CocoaPod file?