Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebP not showing on iOS 12 #298

Closed
kaixinfu opened this issue Sep 26, 2018 · 7 comments
Closed

WebP not showing on iOS 12 #298

kaixinfu opened this issue Sep 26, 2018 · 7 comments

Comments

@kaixinfu
Copy link

"react": "16.5.0",
"react-native": "0.57.1",
"react-native-fast-image": "^5.0.10"
@radeno
Copy link

radeno commented Oct 6, 2018 •
edited
Loading

@liukaixin01
https://github.com/rs/SDWebImage#subspecs

@sesam
Copy link

sesam commented Oct 18, 2018

the link above gives this solution:

By default, you get just Core, so if you need WebP, add it in your Podfile:
pod 'SDWebImage/WebP'

@XHTeng
Copy link

XHTeng commented Oct 25, 2018

the link above gives this solution:

By default, you get just Core, so if you need WebP, add it in your Podfile:
pod 'SDWebImage/WebP'

That will report duplicate references SDWebImage errors . Is there any solution?

@tjbenton
Copy link

I'm having the same issue on iOS, currently I can get alpha webp images(Lossless) to display, but not the solid ones(Lossy). Before attempting to switch to using this library we were using react-native-webp-support and both types of images were displaying correctly.
Here's a screenshot of it using that library and the default react-native Image component. I set the background color of the images to be gray so you could see that they were transparent
screen shot 2018-12-18 at 2 34 46 pm

After attempting to switch to use this library the 1 image that wasn't transparent no longer loads.
screen shot 2018-12-18 at 2 29 05 pm

"react": "16.6.3",
"react-native": "0.57.7",
"react-native-fast-image": "5.1.1",

@ds8k
Copy link

ds8k commented Jan 2, 2019

@radeno @sesam This causes duplicate symbol errors

@sesam
Copy link

sesam commented Jan 2, 2019

@ds8k @XHTeng you should replace pod 'SDWebImage' with pod 'SDWebImage/WebP', or if you need also GIF or MapKit support then use the other syntax that is something like , subspecs: ["Core", "WebP", "MapKit"]
I'm not sure, but it might be that you have to change the code under node_modules/react-native-fast-image just to verify it can work (though hacky and unsustainable), then once we have a tested working correction then we can submot a PR so that DylanVann can release an update.

@xzilja xzilja mentioned this issue Jan 3, 2019
Closed
@ds8k ds8k mentioned this issue Jan 3, 2019
Merged
DylanVann pushed a commit that referenced this issue Feb 22, 2019
@ds8k @DylanVann
fix: Fixes WebP rendering on iOS 12.
d4581c4 
fixes issue #298 #385
@DylanVann DylanVann mentioned this issue Feb 22, 2019
Merged
DylanVann pushed a commit that referenced this issue Feb 22, 2019
@ds8k @DylanVann
fix: Fixes WebP rendering on iOS 12.
90563cf 
fixes issue #298 #385
DylanVann pushed a commit that referenced this issue Feb 22, 2019
@ds8k @DylanVann
fix: Fixes WebP rendering on iOS 12.
714a7f9 
fixes issue #298 #385
DylanVann added a commit that referenced this issue Feb 22, 2019
@DylanVann
fix: Fixes WebP rendering on iOS 12. (#412)
97630c8 
fixes issue #298 #385
DylanVann pushed a commit that referenced this issue Feb 22, 2019
@semantic-release-bot
chore(release): 5.1.3 [skip ci]
4502bc8 
## [5.1.3](v5.1.2...v5.1.3) (2019-02-22)

### Bug Fixes

* Fixes WebP rendering on iOS 12. ([#412](#412)) ([97630c8](97630c8)), closes [#298](#298) [#385](#385)
@DylanVann
Copy link
Owner

Fixed in the latest release! https://github.com/DylanVann/react-native-fast-image/releases/tag/v5.1.3

luffy1701 pushed a commit to luffy1701/react-native-fast-image-v2 that referenced this issue May 9, 2019
@DylanVann
fix: Fixes WebP rendering on iOS 12. (DylanVann#412)
d0f0608 
fixes issue DylanVann#298 DylanVann#385
luffy1701 pushed a commit to luffy1701/react-native-fast-image-v2 that referenced this issue May 9, 2019
@semantic-release-bot
chore(release): 5.1.3 [skip ci]
c5faa31 
## [5.1.3](DylanVann/react-native-fast-image@v5.1.2...v5.1.3) (2019-02-22)

### Bug Fixes

* Fixes WebP rendering on iOS 12. ([DylanVann#412](DylanVann#412)) ([97630c8](DylanVann@97630c8)), closes [DylanVann#298](DylanVann#298) [DylanVann#385](DylanVann#385)
github-actions bot pushed a commit to perrystreetsoftware/react-native-fast-image that referenced this issue Aug 3, 2021
@semantic-release-bot
release(version): Release 6.0.0 [skip ci]
ed0f304 
# [6.0.0](v5.0.11...v6.0.0) (2021-08-03)

### Bug Fixes

* add react@17 as peer dependency ([DylanVann#790](https://github.com/perrystreetsoftware/react-native-fast-image/issues/790)) ([27bd586](27bd586))
* xcode 12 compatibility ([DylanVann#732](https://github.com/perrystreetsoftware/react-native-fast-image/issues/732)) ([23c3955](23c3955))
* **android:** make center ResizeMode work correctly ([d648ef8](d648ef8))
* **android:** remove explicit use of UI thread ([DylanVann#698](https://github.com/perrystreetsoftware/react-native-fast-image/issues/698)) ([5d2894e](5d2894e))
* accessibilityIgnoresInvertColors prop not recognised when using TypeScript ([DylanVann#666](https://github.com/perrystreetsoftware/react-native-fast-image/issues/666)) ([22f89e4](22f89e4)), closes [/github.com/DylanVann/react-native-fast-image/blob/master/src/index.tsx#L150-L160](https://github.com//github.com/DylanVann/react-native-fast-image/blob/master/src/index.tsx/issues/L150-L160)
* Add git tag to CocoaPods source property ([DylanVann#601](https://github.com/perrystreetsoftware/react-native-fast-image/issues/601)) ([2d706ad](2d706ad))
* Add tintColor type definition. ([4adf42f](4adf42f))
* Bump Glide version number to v4.11.0. ([DylanVann#649](https://github.com/perrystreetsoftware/react-native-fast-image/issues/649)) ([c4e4306](c4e4306)), closes [DylanVann#536](https://github.com/perrystreetsoftware/react-native-fast-image/issues/536)
* Fix dependency versions not specified in podfile. ([89f3379](89f3379)), closes [DylanVann#456](https://github.com/perrystreetsoftware/react-native-fast-image/issues/456)
* Fix fallback prop not working. ([DylanVann#420](https://github.com/perrystreetsoftware/react-native-fast-image/issues/420)) ([487d410](487d410))
* Fix IllegalArgumentException crash (Android). ([DylanVann#511](https://github.com/perrystreetsoftware/react-native-fast-image/issues/511)) ([b6c4677](b6c4677))
* Fix incorrect syntax. ([11f6047](11f6047))
* Fix local resource cache issue on Android. ([DylanVann#472](https://github.com/perrystreetsoftware/react-native-fast-image/issues/472)) ([5f65383](5f65383)), closes [DylanVann#402](https://github.com/perrystreetsoftware/react-native-fast-image/issues/402)
* Fix memory leak on iOS. ([DylanVann#433](https://github.com/perrystreetsoftware/react-native-fast-image/issues/433)) ([70be744](70be744))
* Fix peer dependency and remove prop-types. ([44a4c8b](44a4c8b))
* Fix setting props order issue for iOS. ([DylanVann#303](https://github.com/perrystreetsoftware/react-native-fast-image/issues/303)) ([5597ed0](5597ed0)), closes [DylanVann#304](https://github.com/perrystreetsoftware/react-native-fast-image/issues/304)
* Fix wildcard peer dependencies. ([7149420](7149420)), closes [DylanVann#440](https://github.com/perrystreetsoftware/react-native-fast-image/issues/440)
* Fixes cacheControl types. ([DylanVann#382](https://github.com/perrystreetsoftware/react-native-fast-image/issues/382)) ([e13db7d](e13db7d)), closes [DylanVann#325](https://github.com/perrystreetsoftware/react-native-fast-image/issues/325)
* Fixes podspec syntax. ([b627646](b627646))
* Fixes WebP rendering on iOS 12. ([DylanVann#412](https://github.com/perrystreetsoftware/react-native-fast-image/issues/412)) ([97630c8](97630c8)), closes [DylanVann#298](https://github.com/perrystreetsoftware/react-native-fast-image/issues/298) [DylanVann#385](https://github.com/perrystreetsoftware/react-native-fast-image/issues/385)
* Loading images by reverting "bug: Use device scale when loading images.". ([0326c3e](0326c3e)), closes [DylanVann#509](https://github.com/perrystreetsoftware/react-native-fast-image/issues/509)
* peer dependency warning ([DylanVann#653](https://github.com/perrystreetsoftware/react-native-fast-image/issues/653)) ([cd81b1b](cd81b1b))
* remove cache property if using fallback ([ba0f238](ba0f238))
* Replace 'Component' with 'ComponentType' ([DylanVann#647](https://github.com/perrystreetsoftware/react-native-fast-image/issues/647)) ([6abb273](6abb273))
* update SDWebImage and SDWebImageWebPCoder ([DylanVann#689](https://github.com/perrystreetsoftware/react-native-fast-image/issues/689)) ([9646456](9646456))
* Updates SDWebImageWebPCoder. ([DylanVann#628](https://github.com/perrystreetsoftware/react-native-fast-image/issues/628)) ([325d77f](325d77f))
* Upgrade vendored SDWebImage to v5.0.5. ([5016172](5016172)), closes [DylanVann#489](https://github.com/perrystreetsoftware/react-native-fast-image/issues/489)
* wrong cache type ([DylanVann#688](https://github.com/perrystreetsoftware/react-native-fast-image/issues/688)) [skip ci] ([94e2256](94e2256))

### Features

* **ios:** allow for for per-image-request-headers ([DylanVann#691](https://github.com/perrystreetsoftware/react-native-fast-image/issues/691)) ([4a7cd64](4a7cd64))
* Add cookie support for iOS. ([DylanVann#284](https://github.com/perrystreetsoftware/react-native-fast-image/issues/284)) ([ae47bff](ae47bff))
* Add tint color support. ([03c50f0](03c50f0)), closes [DylanVann#124](https://github.com/perrystreetsoftware/react-native-fast-image/issues/124)
* Add tvOS target. ([DylanVann#486](https://github.com/perrystreetsoftware/react-native-fast-image/issues/486)) ([6805972](6805972))
* converts to TypeScript ([DylanVann#642](https://github.com/perrystreetsoftware/react-native-fast-image/issues/642)) ([ac11706](ac11706))
* export ResizeMode and Priority types ([DylanVann#678](https://github.com/perrystreetsoftware/react-native-fast-image/issues/678)) ([e33664f](e33664f))
* Upgrade example apps. ([DylanVann#453](https://github.com/perrystreetsoftware/react-native-fast-image/issues/453)) ([25f8f0d](25f8f0d))
* Upgrade to React Native 0.60.0 / CocoaPods / Android X. ([DylanVann#513](https://github.com/perrystreetsoftware/react-native-fast-image/issues/513)) ([5489f9e](5489f9e))
* Upgrade to SDWebImage 5.0. ([DylanVann#454](https://github.com/perrystreetsoftware/react-native-fast-image/issues/454)) ([8a216e2](8a216e2)), closes [DylanVann#447](https://github.com/perrystreetsoftware/react-native-fast-image/issues/447)
* Use forwardRef to allow access to ref.measure and others. ([DylanVann#419](https://github.com/perrystreetsoftware/react-native-fast-image/issues/419)) ([2b4fba3](2b4fba3)), closes [DylanVann#69](https://github.com/perrystreetsoftware/react-native-fast-image/issues/69)

### Performance Improvements

* Use React.memo for FastImage. ([DylanVann#449](https://github.com/perrystreetsoftware/react-native-fast-image/issues/449)) ([5c2b4af](5c2b4af))

### Reverts

* Remove functionality for notifying other images on load. ([DylanVann#452](https://github.com/perrystreetsoftware/react-native-fast-image/issues/452)) ([292223d](292223d))

### BREAKING CHANGES

* This changes how network requests are handled on iOS. Make sure they still work for you.
* You should upgrade React Native. See https://facebook.github.io/react-native/blog/2019/07/03/version-60
* Upgrade SDWebImage, may affect some projects and CocoaPods users.

Fix the bug of `cacheOnly` behavior
alicayan008 pushed a commit to alicayan008/ReactNative-fast-image that referenced this issue Jul 4, 2023
@semantic-release-bot
chore(release): 5.1.3 [skip ci]
abff6db 
## [5.1.3](DylanVann/react-native-fast-image@v5.1.2...v5.1.3) (2019-02-22)

### Bug Fixes

* Fixes WebP rendering on iOS 12. ([#412](DylanVann/react-native-fast-image#412)) ([97630c8](DylanVann/react-native-fast-image@97630c8)), closes [#298](DylanVann/react-native-fast-image#298) [#385](DylanVann/react-native-fast-image#385)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support WebP images on iOS 12
7 participants
@sesam @radeno @DylanVann @ds8k @tjbenton @XHTeng @kaixinfu