Skip to content

Registered Implementation Diagnostic Entry Tweaks #2048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 11, 2025
Merged

Registered Implementation Diagnostic Entry Tweaks #2048

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d2478d7
Updated registered implementations diagnostic entry to only report no…
bhazen Jun 10, 2025
e59fa33
Always filter default service registrations from diagnostics
josephdecock Jun 11, 2025
2d79ee0
Remove unused references from configuration host
josephdecock Jun 11, 2025
c2738fe
Whitespace nit
josephdecock Jun 11, 2025
da23f34
Clean up DI registrations in EF hosts
josephdecock Jun 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions identity-server/hosts/Configuration/Host.Configuration.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,18 +19,14 @@

<ItemGroup>
<PackageReference Include="Microsoft.AspNetCore.Authentication.Certificate" />
<PackageReference Include="Microsoft.EntityFrameworkCore.Sqlite" />
<PackageReference Include="Microsoft.EntityFrameworkCore.Design" PrivateAssets="All" />
<PackageReference Include="Microsoft.AspNetCore.Mvc.Razor.RuntimeCompilation" />

<PackageReference Include="OpenTelemetry" />
<PackageReference Include="OpenTelemetry.Exporter.Console" />
<PackageReference Include="OpenTelemetry.Exporter.OpenTelemetryProtocol" />
<PackageReference Include="OpenTelemetry.Extensions.Hosting" />
<PackageReference Include="OpenTelemetry.Instrumentation.AspNetCore" />
<PackageReference Include="OpenTelemetry.Instrumentation.Http" />
<PackageReference Include="OpenTelemetry.Instrumentation.SqlClient" />

<PackageReference Include="Serilog.AspNetCore" />
</ItemGroup>

Expand Down
16 changes: 0 additions & 16 deletions identity-server/hosts/EntityFramework-dotnet9/IdentityServerExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@ internal static WebApplicationBuilder ConfigureIdentityServer(this WebApplicatio
})
.AddAppAuthRedirectUriValidator()
.AddServerSideSessions()
.AddScopeParser<ParameterizedScopeParser>()

// this is something you will want in production to reduce load on and requests to the DB
//.AddConfigurationStoreCache()
Expand All @@ -82,21 +81,6 @@ internal static WebApplicationBuilder ConfigureIdentityServer(this WebApplicatio
.AddCustomTokenRequestValidator<ParameterizedScopeTokenRequestValidator>()
.AddScopeParser<ParameterizedScopeParser>()
.AddMutualTlsSecretValidators()

// Comment out `AddInMemoryOidcProviders` if you want to use the seeded identity providers
.AddInMemoryOidcProviders(
[
new Duende.IdentityServer.Models.OidcProvider
{
Scheme = "dynamicprovider-idsvr",
DisplayName = "IdentityServer (via Dynamic Providers)",
Authority = "https://demo.duendesoftware.com",
ClientId = "login",
ResponseType = "id_token",
Scope = "openid profile"
}
])

.AddLicenseSummary();

builder.Services.AddDistributedMemoryCache();
Expand Down
13 changes: 0 additions & 13 deletions identity-server/hosts/EntityFramework/IdentityServerExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,6 @@ internal static WebApplicationBuilder ConfigureIdentityServer(this WebApplicatio
})
.AddAppAuthRedirectUriValidator()
.AddServerSideSessions()
.AddScopeParser<ParameterizedScopeParser>()

// this is something you will want in production to reduce load on and requests to the DB
//.AddConfigurationStoreCache()
Expand All @@ -81,18 +80,6 @@ internal static WebApplicationBuilder ConfigureIdentityServer(this WebApplicatio
.AddCustomTokenRequestValidator<ParameterizedScopeTokenRequestValidator>()
.AddScopeParser<ParameterizedScopeParser>()
.AddMutualTlsSecretValidators()
.AddInMemoryOidcProviders(
[
new Duende.IdentityServer.Models.OidcProvider
{
Scheme = "dynamicprovider-idsvr",
DisplayName = "IdentityServer (via Dynamic Providers)",
Authority = "https://demo.duendesoftware.com",
ClientId = "login",
ResponseType = "id_token",
Scope = "openid profile"
}
])
.AddLicenseSummary();

builder.Services.AddDistributedMemoryCache();
Expand Down
2 changes: 1 addition & 1 deletion identity-server/hosts/Shared/Customization/ParameterizedScopeParser.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ public override void ParseScopeValue(ParseScopeContext scopeContext)
}
else
{
// we get in here with a scope exactly "transaction", which is to say we're ignoring it
// we get in here with a scope exactly "transaction", which is to say we're ignoring it
// and not including it in the results
scopeContext.SetIgnore();
}
Expand Down
6 changes: 6 additions & 0 deletions ...ntityServer/Licensing/V2/Diagnostics/DiagnosticEntries/RegisteredImplementationDetails.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
// Copyright (c) Duende Software. All rights reserved.
// See LICENSE in the project root for license information.

namespace Duende.IdentityServer.Licensing.V2.Diagnostics.DiagnosticEntries;

internal record RegisteredImplementationDetails(Type TInterface, List<Type> TDefaultImplementations);
Loading
Loading