-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] Implement License Screen #883
Merged
momomomo111
merged 15 commits into
DroidKaigi:main
from
fumiya-kume:kuu/add-license-screen
Aug 26, 2023
+44
−1
Merged
Changes from 13 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
d86189c
Add to Gradle version catalog
fumiya-kume 64d50ea
Add dependencies
fumiya-kume 837b806
Replace to navigation logic for license screen
fumiya-kume 4a0b1c0
Update theme for License screen
fumiya-kume ea95eea
Fix plugin handling
fumiya-kume 124d000
Merge branch 'main' into kuu/add-license-screen
takahirom 33966e0
Merge branch 'main' into kuu/add-license-screen
fumiya-kume 86efeeb
Merge branch 'main' into kuu/add-license-screen
fumiya-kume fa3f764
Improve define place for Gradle version catalog
fumiya-kume f4d5d17
Convert to OSS licenses plugin
fumiya-kume 1744bfa
Remove unnecessary library reference
fumiya-kume 488bf27
Fix codeformat by detekt auto-correct
fumiya-kume b1109b0
Revert unnecessary theme changes
fumiya-kume f318919
Switching theme based on device night module config
fumiya-kume c06afc0
Merge branch 'main' into kuu/add-license-screen
takahirom File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -98,6 +98,10 @@ gradlePlugin { | |
id = "droidkaigi.primitive.detekt" | ||
implementationClass = "io.github.droidkaigi.confsched2023.primitive.DetektPlugin" | ||
} | ||
register("oss-licenses") { | ||
id = "droidkaigi.primitive.osslicenses" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks! We might have to use |
||
implementationClass = "io.github.droidkaigi.confsched2023.primitive.OssLicensesPlugin" | ||
} | ||
|
||
// Conventions | ||
register("androidFeature") { | ||
|
17 changes: 17 additions & 0 deletions
17
build-logic/src/main/kotlin/io/github/droidkaigi/confsched2023/primitive/OssLicensePlugin.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
package io.github.droidkaigi.confsched2023.primitive | ||
|
||
import org.gradle.api.Plugin | ||
import org.gradle.api.Project | ||
import org.gradle.kotlin.dsl.dependencies | ||
|
||
class OssLicensesPlugin : Plugin<Project> { | ||
override fun apply(target: Project) { | ||
with(target) { | ||
pluginManager.apply("com.google.android.gms.oss-licenses-plugin") | ||
|
||
dependencies { | ||
implementation(libs.library("ossLicenses")) | ||
} | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 Specify the AppCompat theme for the
OSS license plugin
's screen