[feature] Implement License Screen #883

fumiya-kume · 2023-08-22T14:14:09Z

Issue

close Implement License Screen #438

Overview (Required)

Add plugin to apply the OSS Licenses Gradle Plugin
Add navigation logic for the license screen which generated the plugin.
Add theme config for the generated Activities by the plugin.

Title of the screen

I created the issue #938

TODO

Solve issue that refer the LicensePlugin with Gradle Version Catalog
Solve issue that I'd like to not changing the theme...

Links

Screenshot (Optional if screenshot test is present or unrelated to UI)

Before	After

Movie of License screen behavior

Before	After
N/A	license-qa.webm

takahirom · 2023-08-22T15:11:32Z

app-android/src/main/res/values/themes.xml

@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="utf-8"?>
 <resources>

-    <style name="Theme.KaigiApp" parent="android:Theme.Material.Light.NoActionBar">
+    <style name="Theme.KaigiApp" parent="Theme.AppCompat.Light.NoActionBar">


🙏
(I thought it is ok to have this theme 👀 )

let me check with revert ver 🙇

I don't have to change the theme for entire the app.

I can just update the theme for the Activities which generate by the plugin.

takahirom · 2023-08-22T15:12:53Z

gradle/libs.versions.toml


+# etc
+
+ossLicenses = { module = "com.google.android.gms:play-services-oss-licenses", version.ref = "ossLicenses" }
+ossLicensesPlugin = { module = "com.google.android.gms:oss-licenses-plugin", version.ref = "ossLicensesPlugin" }


How about placing these dependencies below the dependencies for tests?

That's make sense. thank you for suggestion!

I moved to below of tests

takahirom · 2023-08-22T15:19:05Z

build.gradle.kts

+    dependencies {
+        classpath(libs.ossLicensesPlugin)
+    }


Please refer here to add this plugin.
https://github.com/DroidKaigi/conference-app-2023/blob/main/build-logic/build.gradle.kts
Or there is a blog reading this. You can refer to it 👍
https://sys1yagi.hatenablog.com/entry/2023/08/17/151450

Thank you for recommendations!
I'm not family with this, so much helpful 🙇

I created the Plugin for OSS license plugin.

also It applied.

github-actions · 2023-08-22T16:12:22Z

Test Results

190 tests 190 ✔️ 7m 12s ⏱️
  11 suites     0 💤
  11 files     0 ❌

Results for commit c06afc0.

♻️ This comment has been updated with latest results.

github-actions · 2023-08-23T15:14:55Z

Hi @fumiya-kume! Codes seem to be unformatted. To resolve this issue, please run ./gradlew detekt --auto-correct and fix the results of ./gradlew lintDebug.. Thank you for your contribution.

fumiya-kume · 2023-08-24T10:49:17Z

app-android/src/main/AndroidManifest.xml

@@ -28,6 +28,14 @@
            </intent-filter>
        </activity>

+        <activity


📝 Specify the AppCompat theme for the OSS license plugin's screen

takahirom · 2023-08-25T09:04:22Z

build-logic/build.gradle.kts

@@ -98,6 +98,10 @@ gradlePlugin {
            id = "droidkaigi.primitive.detekt"
            implementationClass = "io.github.droidkaigi.confsched2023.primitive.DetektPlugin"
        }
+        register("oss-licenses") {
+            id = "droidkaigi.primitive.osslicenses"


Thanks! We might have to use droidkaigi.primitive.*android*.osslicenses because the license list plugin is based on AGP plugin.

takahirom · 2023-08-25T09:05:34Z

Almost LGTM! Thanks

momomomo111

After verifying, the license displayed correctly in the release environment, but it did not function properly in the debug environment.
If this is the intended behavior, then I believe it's fine.
Thank you for contributing!!👍

fumiya-kume · 2023-08-25T10:34:58Z

After verifying, the license displayed correctly in the release environment, but it did not function properly in the debug environment.

If this is the intended behavior, then I believe it's fine.

Thank you for contributing!!👍

I don't have much experience with the plug-in, then I'd hear other person's opinion if there.

I other hand, I confirmed that the behavior already.

tarumzu · 2023-08-25T15:40:17Z

@momomomo111 oss-licenses-plugin-v0.10.5 and later are only visible in release builds.

google/play-services-plugins@138a15d (#216)

fumiya-kume added 4 commits August 22, 2023 23:17

Add to Gradle version catalog

d86189c

Add dependencies

64d50ea

Replace to navigation logic for license screen

837b806

Update theme for License screen

4a0b1c0

fumiya-kume force-pushed the kuu/add-license-screen branch from e7dda6e to 4a0b1c0 Compare August 22, 2023 14:19

fumiya-kume changed the title ~~Kuu/add license screen~~ [feature] Add license screen Aug 22, 2023

Fix plugin handling

ea95eea

fumiya-kume changed the title ~~[feature] Add license screen~~ [feature] Implement License Screen Aug 22, 2023

takahirom reviewed Aug 22, 2023

View reviewed changes

github-actions bot temporarily deployed to deploygate-distribution August 22, 2023 16:29 Inactive

DroidKaigi deleted a comment from github-actions bot Aug 22, 2023

Merge branch 'main' into kuu/add-license-screen

124d000

github-actions bot temporarily deployed to deploygate-distribution August 22, 2023 23:30 Inactive

Merge branch 'main' into kuu/add-license-screen

33966e0

github-actions bot temporarily deployed to deploygate-distribution August 23, 2023 15:49 Inactive

fumiya-kume added 6 commits August 24, 2023 18:26

Merge branch 'main' into kuu/add-license-screen

86efeeb

Improve define place for Gradle version catalog

fa3f764

Convert to OSS licenses plugin

f4d5d17

Remove unnecessary library reference

1744bfa

Fix codeformat by detekt auto-correct

488bf27

Revert unnecessary theme changes

b1109b0

fumiya-kume commented Aug 24, 2023

View reviewed changes

fumiya-kume marked this pull request as ready for review August 24, 2023 11:01

fumiya-kume requested a review from a team as a code owner August 24, 2023 11:01

fumiya-kume requested review from momomomo111 and takahirom August 24, 2023 11:01

Switching theme based on device night module config

f318919

github-actions bot temporarily deployed to deploygate-distribution August 24, 2023 12:27 Inactive

takahirom reviewed Aug 25, 2023

View reviewed changes

momomomo111 approved these changes Aug 25, 2023

View reviewed changes

Merge branch 'main' into kuu/add-license-screen

c06afc0

github-actions bot temporarily deployed to deploygate-distribution August 26, 2023 09:50 Inactive

momomomo111 merged commit 10c25bd into DroidKaigi:main Aug 26, 2023

fumiya-kume mentioned this pull request Aug 29, 2023

Fix oss licenses plugin id #1017

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[feature] Implement License Screen #883

[feature] Implement License Screen #883

fumiya-kume commented Aug 22, 2023 •

edited

Loading

takahirom Aug 22, 2023 •

edited

Loading

fumiya-kume Aug 23, 2023

fumiya-kume Aug 24, 2023

takahirom Aug 22, 2023

fumiya-kume Aug 23, 2023

fumiya-kume Aug 24, 2023

takahirom Aug 22, 2023

fumiya-kume Aug 22, 2023

fumiya-kume Aug 24, 2023 •

edited

Loading

github-actions bot commented Aug 22, 2023 •

edited

Loading

github-actions bot commented Aug 23, 2023

fumiya-kume Aug 24, 2023

takahirom Aug 25, 2023 •

edited

Loading

takahirom commented Aug 25, 2023

momomomo111 left a comment

fumiya-kume commented Aug 25, 2023

tarumzu commented Aug 25, 2023 •

edited

Loading

[feature] Implement License Screen #883

[feature] Implement License Screen #883

Conversation

fumiya-kume commented Aug 22, 2023 • edited Loading

Issue

Overview (Required)

Title of the screen

TODO

Links

Screenshot (Optional if screenshot test is present or unrelated to UI)

Movie of License screen behavior

takahirom Aug 22, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fumiya-kume Aug 24, 2023 • edited Loading

Choose a reason for hiding this comment

github-actions bot commented Aug 22, 2023 • edited Loading

Test Results

github-actions bot commented Aug 23, 2023

Choose a reason for hiding this comment

takahirom Aug 25, 2023 • edited Loading

Choose a reason for hiding this comment

takahirom commented Aug 25, 2023

momomomo111 left a comment

Choose a reason for hiding this comment

fumiya-kume commented Aug 25, 2023

tarumzu commented Aug 25, 2023 • edited Loading

fumiya-kume commented Aug 22, 2023 •

edited

Loading

takahirom Aug 22, 2023 •

edited

Loading

fumiya-kume Aug 24, 2023 •

edited

Loading

github-actions bot commented Aug 22, 2023 •

edited

Loading

takahirom Aug 25, 2023 •

edited

Loading

tarumzu commented Aug 25, 2023 •

edited

Loading