feat(desktop): localize native Electron UI in Russian - #2
Open
londo161 wants to merge 1 commit into
Open
Conversation
|
Analysis CompleteGenerated ECC bundle from 1 commits | Confidence: 50% View Pull Request #3Repository Profile
Changed Files (4)
Top hotspots
Top directories
Analysis Depth Readiness (commit-history, 7%)ECC Tools uses this to decide whether recommendations should stay at commit-history/setup guidance or expand into CI, security, harness, reference-set, AI-routing, and team backlog work.
Reference Set Readiness (0/7, 0%)
Generated Instincts (5)
After merging, import with: Files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
native-copymodule for English/Russian Electron main-process copyelectron.app.getLocale()after app readiness, with an early-startupIntlfallback and English fallback for unsupported localescurrentNativeCopy()assets/ru.lproj/InfoPlist.stringsRelationship to upstream PR
This is a focused native/macOS follow-up to NousResearch#72250 and is intentionally based on its exact head (
82fab96e927ca1ea753cf3eadc231ac2c996fa12). It does not duplicate or replace the reviewed renderer catalog in that PR.Only four files are changed:
apps/desktop/electron/main.tsapps/desktop/electron/native-copy.tsapps/desktop/electron/native-copy.test.tsapps/desktop/assets/ru.lproj/InfoPlist.stringsValidation
0,0diagnosticsvitest run electron/native-copy.test.ts: 1 file / 2 tests passedplutil -lint apps/desktop/assets/ru.lproj/InfoPlist.strings: OKgit diff --check: cleanThe full original localization commit is also preserved separately in
londo161/hermes-agent:feat/desktop-ru-complete-v020; this PR contains only the non-duplicative native integration.