Skip to content

feat(desktop): localize native Electron UI in Russian - #2

Open
londo161 wants to merge 1 commit into
DrMaks22:codex/ru-desktop-canonicalfrom
londo161:feat/desktop-ru-native-copy-72250
Open

feat(desktop): localize native Electron UI in Russian#2
londo161 wants to merge 1 commit into
DrMaks22:codex/ru-desktop-canonicalfrom
londo161:feat/desktop-ru-native-copy-72250

Conversation

@londo161

@londo161 londo161 commented Aug 9, 2026

Copy link
Copy Markdown

Summary

  • add a small typed native-copy module for English/Russian Electron main-process copy
  • resolve Russian from electron.app.getLocale() after app readiness, with an early-startup Intl fallback and English fallback for unsupported locales
  • route user-visible boot/update progress, native menus, image actions, quit prompts, runtime status, and related main-process strings through currentNativeCopy()
  • add Russian macOS camera/microphone/audio-capture permission descriptions in assets/ru.lproj/InfoPlist.strings
  • add focused locale/fallback/plural/path-preservation tests

Relationship to upstream PR

This is a focused native/macOS follow-up to NousResearch#72250 and is intentionally based on its exact head (82fab96e927ca1ea753cf3eadc231ac2c996fa12). It does not duplicate or replace the reviewed renderer catalog in that PR.

Only four files are changed:

  • apps/desktop/electron/main.ts
  • apps/desktop/electron/native-copy.ts
  • apps/desktop/electron/native-copy.test.ts
  • apps/desktop/assets/ru.lproj/InfoPlist.strings

Validation

  • Electron TypeScript SolutionBuilder: status 0, 0 diagnostics
  • vitest run electron/native-copy.test.ts: 1 file / 2 tests passed
  • Prettier exact check: 3/3 TypeScript files formatted
  • plutil -lint apps/desktop/assets/ru.lproj/InfoPlist.strings: OK
  • git diff --check: clean

The full original localization commit is also preserved separately in londo161/hermes-agent:feat/desktop-ru-complete-v020; this PR contains only the non-duplicative native integration.

@ecc-tools

ecc-tools Bot commented Aug 9, 2026

Copy link
Copy Markdown

Analyzing 200 commits...

@ecc-tools

ecc-tools Bot commented Aug 9, 2026

Copy link
Copy Markdown

Analysis Complete

Generated ECC bundle from 1 commits | Confidence: 50%

View Pull Request #3

Repository Profile
Attribute Value
Language TypeScript
Framework Not detected
Commit Convention conventional
Test Directory mixed
Changed Files (4)
Metric Value
Files changed 4
Additions 281
Deletions 28

Top hotspots

Path Status +/-
apps/desktop/electron/native-copy.ts added +220 / -0
apps/desktop/electron/main.ts modified +34 / -28
apps/desktop/electron/native-copy.test.ts added +24 / -0
apps/desktop/assets/ru.lproj/InfoPlist.strings added +3 / -0

Top directories

Directory Files Total changes
apps/desktop/electron 3 306
apps/desktop/assets/ru.lproj 1 3
Analysis Depth Readiness (commit-history, 7%)

ECC Tools uses this to decide whether recommendations should stay at commit-history/setup guidance or expand into CI, security, harness, reference-set, AI-routing, and team backlog work.

Area Status Evidence / Next Step
Commit history Partial 1 commits sampled
CI/CD signals Missing Add workflow files or CI troubleshooting evidence so ECC Tools can reason about pipeline setup.
Security evidence Missing Add AgentShield, audit, SARIF, SBOM, or security review evidence so recommendations can cover security posture.
Harness configuration Missing Add Claude, Codex, OpenCode, Zed, dmux, MCP, plugin, or cross-harness config evidence for harness-agnostic recommendations.
Reference/eval evidence Missing Add fixtures, golden traces, reference sets, or evaluator benchmarks so deeper recommendations have regression evidence.
AI routing and cost controls Missing Add model-routing, budget, usage, or cost-control files before relying on AI-heavy automation recommendations.
Team handoff and project tracking Missing Add roadmap, runbook, project, Linear, or follow-up tracking docs so generated work can land in a team queue.
Reference Set Readiness (0/7, 0%)
Area Status Evidence / Next Step
Deep analyzer corpus Missing Add analyzer fixture, golden, benchmark, or reference-set files that can catch analyzer regressions.
RAG/evaluator comparison Missing Add retrieval or evaluator reference-set comparison fixtures with expected ranking behavior.
PR salvage/review corpus Missing Add stale-PR, review-thread, reopen-flow, or salvage reference cases for queue cleanup automation.
Discussion triage corpus Missing Add public discussion triage fixtures, golden cases, or reference sets for informational, answered, and no-response classifications.
Harness compatibility Missing Add cross-harness, adapter-compliance, or harness-audit evidence for Claude, Codex, OpenCode, Zed, dmux, and agent surfaces.
Security evidence Missing Attach security evidence such as SBOMs, SARIF, audit reports, or AgentShield evidence packs.
CI failure-mode evidence Missing Add captured CI failure logs, dry-run fixtures, or troubleshooting docs for common workflow failure modes.
Generated Instincts (5)
Domain Count
git 2
code-style 3

After merging, import with:

/instinct-import .claude/homunculus/instincts/inherited/hermes-agent-instincts.yaml

Files

  • .claude/ecc-tools.json
  • .claude/skills/hermes-agent/SKILL.md
  • .agents/skills/hermes-agent/SKILL.md
  • .agents/skills/hermes-agent/agents/openai.yaml
  • .claude/identity.json
  • .codex/config.toml
  • .codex/AGENTS.md
  • .codex/agents/explorer.toml
  • .codex/agents/reviewer.toml
  • .codex/agents/docs-researcher.toml
  • .claude/homunculus/instincts/inherited/hermes-agent-instincts.yaml

ECC Tools | Everything Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant