Skip to content

feat(server): add volume support#641

Merged
Benoît Cortier (CBenoit) merged 1 commit intoDevolutions:masterfrom
elmarco:volume
Jan 27, 2025
Merged

feat(server): add volume support#641
Benoît Cortier (CBenoit) merged 1 commit intoDevolutions:masterfrom
elmarco:volume

Conversation

@elmarco
Copy link
Copy Markdown
Contributor

Add server messages and API to support setting client volume.

Copy link
Copy Markdown
Member

@CBenoit Benoît Cortier (CBenoit) left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@CBenoit
Copy link
Copy Markdown
Member

Benoît Cortier (CBenoit) commented Jan 24, 2025

CI is broken for macOS WASM check. It appears the WebAssembly/wabt project deleted the macOS 14 artifacts for the release v1.0.33 we were relying on 🤷
I’ll fix that in a separate PR.

@elmarco
Copy link
Copy Markdown
Contributor Author

Marc-Andre Lureau (elmarco) commented Jan 24, 2025

it's fixed in #630 9cb217b

@CBenoit
Copy link
Copy Markdown
Member

Benoît Cortier (CBenoit) commented Jan 24, 2025

Indeed, I cherry-picked it to be merged in a separate PR: #642

Auto-merge is enabled on this PR, so hopefully it should be merged as soon as you rebase it on master.

Add server messages and API to support setting client volume.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
auto-merge was automatically disabled January 27, 2025 13:00

Head branch was pushed to by a user without write access

@CBenoit Benoît Cortier (CBenoit) merged commit a6c3651 into Devolutions:master Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants