Skip to content

chore(release): prepare for publishing#628

Merged
Benoît Cortier (CBenoit) merged 2 commits intomasterfrom
release-plz/2025-01-06T14-33-15Z
Jan 28, 2025
Merged

chore(release): prepare for publishing#628
Benoît Cortier (CBenoit) merged 2 commits intomasterfrom
release-plz/2025-01-06T14-33-15Z

Conversation

@devolutionsbot
Copy link
Copy Markdown
Contributor

@devolutionsbot devolutionsbot commented Jan 6, 2025 •
edited
Loading

🤖 New release

  • ironrdp: 0.7.3 -> 0.7.4 (✓ API compatible changes)
  • ironrdp-acceptor: 0.2.1 -> 0.3.0 (⚠️ API breaking changes)
  • ironrdp-async: 0.2.1 -> 0.3.0 (⚠️ API breaking changes)
  • ironrdp-connector: 0.2.2 -> 0.3.0 (⚠️ API breaking changes)
  • ironrdp-core: 0.1.2 -> 0.1.3 (✓ API compatible changes)
  • ironrdp-error: 0.1.1 -> 0.1.2 (✓ API compatible changes)
  • ironrdp-pdu: 0.1.2 -> 0.2.0 (⚠️ API breaking changes)
  • ironrdp-svc: 0.1.2 -> 0.1.3 (✓ API compatible changes)
  • ironrdp-cliprdr: 0.1.1 -> 0.1.2 (✓ API compatible changes)
  • ironrdp-displaycontrol: 0.1.1 -> 0.1.2 (✓ API compatible changes)
  • ironrdp-dvc: 0.1.1 -> 0.1.2 (✓ API compatible changes)
  • ironrdp-graphics: 0.1.1 -> 0.1.2 (✓ API compatible changes)
  • ironrdp-input: 0.1.1 -> 0.1.2 (✓ API compatible changes)
  • ironrdp-rdpdr: 0.1.1 -> 0.1.2 (✓ API compatible changes)
  • ironrdp-rdpsnd: 0.1.1 -> 0.2.0 (⚠️ API breaking changes)
  • ironrdp-server: 0.4.0 -> 0.4.1 (✓ API compatible changes)
  • ironrdp-ainput: 0.1.1 -> 0.1.2 (✓ API compatible changes)
  • ironrdp-tokio: 0.2.1 -> 0.2.2 (✓ API compatible changes)
  • ironrdp-session: 0.2.1 -> 0.2.2 (✓ API compatible changes)
  • ironrdp-blocking: 0.2.1 -> 0.3.0 (⚠️ API breaking changes)
  • ironrdp-cliprdr-native: 0.1.1 -> 0.1.2 (✓ API compatible changes)
  • ironrdp-rdpsnd-native: 0.1.1 -> 0.1.2 (✓ API compatible changes)
  • ironrdp-tls: 0.1.1 -> 0.1.2 (✓ API compatible changes)
  • ironrdp-cliprdr-format: 0.1.1 -> 0.1.2 (✓ API compatible changes)
  • ironrdp-futures: 0.1.1 -> 0.1.2 (✓ API compatible changes)
  • ironrdp-rdcleanpath: 0.1.1 -> 0.1.2 (✓ API compatible changes)

⚠️ ironrdp-acceptor breaking changes

--- failure constructible_struct_adds_field: externally-constructible struct adds field ---

Description:
A pub struct constructible with a struct literal has a new pub field. Existing struct literals must be updated to include the new field.
        ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.38.0/src/lints/constructible_struct_adds_field.ron

Failed in:
  field AcceptorResult.reactivation in /tmp/.tmpUC3sKl/IronRDP/crates/ironrdp-acceptor/src/connection.rs:46

--- failure function_parameter_count_changed: pub fn parameter count changed ---

Description:
A publicly-visible function now takes a different number of parameters.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.38.0/src/lints/function_parameter_count_changed.ron

Failed in:
  ironrdp_acceptor::accept_finalize now takes 2 parameters instead of 3, in /tmp/.tmpUC3sKl/IronRDP/crates/ironrdp-acceptor/src/lib.rs:83

--- failure method_parameter_count_changed: pub method parameter count changed ---

Description:
A publicly-visible method now takes a different number of parameters.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.38.0/src/lints/method_parameter_count_changed.ron

Failed in:
  ironrdp_acceptor::Acceptor::new_deactivation_reactivation now takes 3 parameters instead of 2, in /tmp/.tmpUC3sKl/IronRDP/crates/ironrdp-acceptor/src/connection.rs:70

⚠️ ironrdp-async breaking changes

--- failure function_parameter_count_changed: pub fn parameter count changed ---

Description:
A publicly-visible function now takes a different number of parameters.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.38.0/src/lints/function_parameter_count_changed.ron

Failed in:
  ironrdp_async::single_sequence_step now takes 3 parameters instead of 4, in /tmp/.tmpUC3sKl/IronRDP/crates/ironrdp-async/src/framed.rs:229
  ironrdp_async::single_sequence_step_read now takes 3 parameters instead of 4, in /tmp/.tmpUC3sKl/IronRDP/crates/ironrdp-async/src/framed.rs:242

--- failure method_parameter_count_changed: pub method parameter count changed ---

Description:
A publicly-visible method now takes a different number of parameters.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.38.0/src/lints/method_parameter_count_changed.ron

Failed in:
  ironrdp_async::Framed::read_by_hint now takes 2 parameters instead of 3, in /tmp/.tmpUC3sKl/IronRDP/crates/ironrdp-async/src/framed.rs:168

⚠️ ironrdp-connector breaking changes

--- failure constructible_struct_adds_field: externally-constructible struct adds field ---

Description:
A pub struct constructible with a struct literal has a new pub field. Existing struct literals must be updated to include the new field.
        ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.38.0/src/lints/constructible_struct_adds_field.ron

Failed in:
  field LicenseExchangeSequence.hardware_id in /tmp/.tmpUC3sKl/IronRDP/crates/ironrdp-connector/src/license_exchange.rs:62
  field LicenseExchangeSequence.license_cache in /tmp/.tmpUC3sKl/IronRDP/crates/ironrdp-connector/src/license_exchange.rs:63
  field Config.hardware_id in /tmp/.tmpUC3sKl/IronRDP/crates/ironrdp-connector/src/lib.rs:168
  field Config.license_cache in /tmp/.tmpUC3sKl/IronRDP/crates/ironrdp-connector/src/lib.rs:178

--- failure method_parameter_count_changed: pub method parameter count changed ---

Description:
A publicly-visible method now takes a different number of parameters.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.38.0/src/lints/method_parameter_count_changed.ron

Failed in:
  ironrdp_connector::LicenseExchangeSequence::new now takes 5 parameters instead of 3, in /tmp/.tmpUC3sKl/IronRDP/crates/ironrdp-connector/src/license_exchange.rs:86

⚠️ ironrdp-pdu breaking changes

--- failure enum_variant_added: enum variant added on exhaustive enum ---

Description:
A publicly-visible enum without #[non_exhaustive] has a new variant.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#enum-variant-new
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.38.0/src/lints/enum_variant_added.ron

Failed in:
  variant LicensePdu:ClientLicenseInfo in /tmp/.tmpUC3sKl/IronRDP/crates/ironrdp-pdu/src/rdp/server_license.rs:346

--- failure struct_missing: pub struct removed or renamed ---

Description:
A publicly-visible struct cannot be imported by its prior path. A `pub use` may have been removed, or the struct itself may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.38.0/src/lints/struct_missing.ron

Failed in:
  struct ironrdp_pdu::rdp::server_license::NewLicenseInformation, previously in file /tmp/.tmp7gindJ/ironrdp-pdu/src/rdp/server_license/server_upgrade_license.rs:98

⚠️ ironrdp-rdpsnd breaking changes

--- failure enum_variant_added: enum variant added on exhaustive enum ---

Description:
A publicly-visible enum without #[non_exhaustive] has a new variant.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#enum-variant-new
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.38.0/src/lints/enum_variant_added.ron

Failed in:
  variant RdpsndServerMessage:SetVolume in /tmp/.tmpUC3sKl/IronRDP/crates/ironrdp-rdpsnd/src/server.rs:20

⚠️ ironrdp-blocking breaking changes

--- failure function_parameter_count_changed: pub fn parameter count changed ---

Description:
A publicly-visible function now takes a different number of parameters.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.38.0/src/lints/function_parameter_count_changed.ron

Failed in:
  ironrdp_blocking::single_sequence_step now takes 3 parameters instead of 4, in /tmp/.tmpUC3sKl/IronRDP/crates/ironrdp-blocking/src/connector.rs:187

--- failure method_parameter_count_changed: pub method parameter count changed ---

Description:
A publicly-visible method now takes a different number of parameters.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.38.0/src/lints/method_parameter_count_changed.ron

Failed in:
  ironrdp_blocking::Framed::read_by_hint now takes 2 parameters instead of 3, in /tmp/.tmpUC3sKl/IronRDP/crates/ironrdp-blocking/src/framed.rs:90
Changelog

ironrdp

[0.7.4] - 2025-01-28

Features

Bug Fixes

Documentation

ironrdp-acceptor

[0.3.0] - 2025-01-28

Security

Bug Fixes

  • Drop unexpected PDUs during deactivation-reactivation (63963182b5)

    The current behaviour of handling unmatched PDUs in fn read_by_hint()
    isn't good enough. An unexpected PDUs may be received and fail to be
    decoded during Acceptor::step().

    Change the code to simply drop unexpected PDUs (as opposed to attempting
    to replay the unmatched leftover, which isn't clearly needed)

  • Reattach existing channels (c4587b537c)

    I couldn't find any explicit behaviour described in the specification,
    but apparently, we must just keep the channel state as they were during
    reactivation. This fixes various state issues during client resize.

  • Do not restart static channels on reactivation (82c7c2f5b0)

Documentation

ironrdp-async

[0.3.0] - 2025-01-28

Bug Fixes

  • Drop unexpected PDUs during deactivation-reactivation (63963182b5)

    The current behaviour of handling unmatched PDUs in fn read_by_hint()
    isn't good enough. An unexpected PDUs may be received and fail to be
    decoded during Acceptor::step().

    Change the code to simply drop unexpected PDUs (as opposed to attempting
    to replay the unmatched leftover, which isn't clearly needed)

Documentation

ironrdp-connector

[0.3.0] - 2025-01-28

Features

  • Support license caching (feat: support license caching #634) (dd221bf224)

    Adds support for license caching by storing the license obtained
    from SERVER_UPGRADE_LICENSE message and sending
    CLIENT_LICENSE_INFO if a license requested by the server is already
    stored in the cache.

Documentation

Build

ironrdp-core

[0.1.3] - 2025-01-28

Documentation

ironrdp-error

[0.1.2] - 2025-01-28

Documentation

ironrdp-pdu

[0.2.0] - 2025-01-28

Features

  • Support license caching (feat: support license caching #634) (dd221bf224)

    Adds support for license caching by storing the license obtained
    from SERVER_UPGRADE_LICENSE message and sending
    CLIENT_LICENSE_INFO if a license requested by the server is already
    stored in the cache.

Documentation

ironrdp-svc

[0.1.3] - 2025-01-28

Documentation

ironrdp-cliprdr

[0.1.2] - 2025-01-28

Documentation

ironrdp-displaycontrol

[0.1.2] - 2025-01-28

Documentation

ironrdp-dvc

[0.1.2] - 2025-01-28

Features

  • Some debug statement on invalid channel state (265b661b81)

  • Add CreationStatus::NOT_FOUND (ab8a87d942)

    For completeness, this error is used by FreeRDP.

Documentation

ironrdp-graphics

[0.1.2] - 2025-01-28

Documentation

ironrdp-input

[0.1.2] - 2025-01-28

Documentation

ironrdp-rdpdr

[0.1.2] - 2025-01-28

Documentation

ironrdp-rdpsnd

[0.2.0] - 2025-01-28

Features

Documentation

ironrdp-server

[0.4.1] - 2025-01-28

Features

  • Advertize Bitmap::desktopResizeFlag (a0fccf8d1a)

    This makes freerdp keep the flag up and handle desktop
    resize/deactivation-reactivation. It should be okay to advertize,
    if the server doesn't resize anyway, I guess.

  • Add volume support (feat(server): add volume support #641) (a6c36511f6)

    Add server messages and API to support setting client volume.

Bug Fixes

  • Drop unexpected PDUs during deactivation-reactivation (63963182b5)

    The current behaviour of handling unmatched PDUs in fn read_by_hint()
    isn't good enough. An unexpected PDUs may be received and fail to be
    decoded during Acceptor::step().

    Change the code to simply drop unexpected PDUs (as opposed to attempting
    to replay the unmatched leftover, which isn't clearly needed)

  • Reattach existing channels (c4587b537c)

    I couldn't find any explicit behaviour described in the specification,
    but apparently, we must just keep the channel state as they were during
    reactivation. This fixes various state issues during client resize.

  • Do not restart static channels on reactivation (82c7c2f5b0)

  • Check client size (0f9877ad39)

    It's problematic when the client didn't resize, as we send bitmap
    updates that don't fit. The client will likely drop the connection.
    Let's have a warning for this case in the server.

Documentation

ironrdp-ainput

[0.1.2] - 2025-01-28

Documentation

ironrdp-tokio

[0.2.2] - 2025-01-28

Documentation

ironrdp-session

[0.2.2] - 2025-01-28

Documentation

ironrdp-blocking

[0.3.0] - 2025-01-28

Bug Fixes

  • Drop unexpected PDUs during deactivation-reactivation (63963182b5)

    The current behaviour of handling unmatched PDUs in fn read_by_hint()
    isn't good enough. An unexpected PDUs may be received and fail to be
    decoded during Acceptor::step().

    Change the code to simply drop unexpected PDUs (as opposed to attempting
    to replay the unmatched leftover, which isn't clearly needed)

Documentation

ironrdp-cliprdr-native

[0.1.2] - 2025-01-28

Documentation

ironrdp-rdpsnd-native

[0.1.2] - 2025-01-28

Documentation

ironrdp-tls

[0.1.2] - 2025-01-28

Documentation

Build

ironrdp-cliprdr-format

[0.1.2] - 2025-01-28

Documentation

ironrdp-futures

[0.1.2] - 2025-01-28

Documentation

ironrdp-rdcleanpath

[0.1.2] - 2025-01-28

Documentation

This PR was generated with release-plz.

@github-actions github-actions Bot force-pushed the release-plz/2025-01-06T14-33-15Z branch from d92e2eb to a09603c Compare January 6, 2025 14:33
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 6, 2025 •
edited
Loading

Coverage Report 🤖 ⚙️

Past:
Total lines: 30477
Covered lines: 19597 (64.30%)

New:
Total lines: 30477
Covered lines: 19606 (64.33%)

Diff: +0.03%

[this comment will be updated automatically]

@github-actions github-actions Bot force-pushed the release-plz/2025-01-06T14-33-15Z branch 4 times, most recently from cf7ad68 to 23ef120 Compare January 9, 2025 15:19
@github-actions github-actions Bot force-pushed the release-plz/2025-01-06T14-33-15Z branch 10 times, most recently from dcafb06 to 994ee79 Compare January 21, 2025 00:03
@github-actions github-actions Bot force-pushed the release-plz/2025-01-06T14-33-15Z branch 10 times, most recently from 6565df7 to ae6d737 Compare January 28, 2025 10:10
@elmarco
Copy link
Copy Markdown
Contributor

Marc-Andre Lureau (elmarco) commented Jan 28, 2025

Benoît Cortier (@CBenoit) anything I can do to help for the next release? :) many thanks

@github-actions github-actions Bot force-pushed the release-plz/2025-01-06T14-33-15Z branch 2 times, most recently from 307c37d to 770e2a0 Compare January 28, 2025 13:08
@CBenoit
Copy link
Copy Markdown
Member

Benoît Cortier (CBenoit) commented Jan 28, 2025

Benoît Cortier (@CBenoit) anything I can do to help for the next release? :) many thanks

Thank you!

I was looking at some of the breaking changes, especially about some auto-traits being not implemented anymore:

--- failure auto_trait_impl_removed: auto trait no longer implemented ---

Description:
A public type has stopped implementing one or more auto traits. This can break downstream code that depends on the traits being implemented.
        ref: https://doc.rust-lang.org/reference/special-types-and-traits.html#auto-traits
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.38.0/src/lints/auto_trait_impl_removed.ron

Failed in:
  type ProcessorOutput is no longer UnwindSafe, in /tmp/.tmppi9kAf/IronRDP/crates/ironrdp-session/src/x224/mod.rs:15
  type ProcessorOutput is no longer RefUnwindSafe, in /tmp/.tmppi9kAf/IronRDP/crates/ironrdp-session/src/x224/mod.rs:15
  type ActiveStageOutput is no longer UnwindSafe, in /tmp/.tmppi9kAf/IronRDP/crates/ironrdp-session/src/active_stage.rs:251
  type ActiveStageOutput is no longer RefUnwindSafe, in /tmp/.tmppi9kAf/IronRDP/crates/ironrdp-session/src/active_stage.rs:251

@github-actions github-actions Bot force-pushed the release-plz/2025-01-06T14-33-15Z branch 2 times, most recently from 1a7b3c2 to 6f74043 Compare January 28, 2025 13:40
@elmarco
Copy link
Copy Markdown
Contributor

Marc-Andre Lureau (elmarco) commented Jan 28, 2025

type ProcessorOutput is no longer UnwindSafe, in /tmp/.tmppi9kAf/IronRDP/crates/ironrdp-session/src/x224/mod.rs:15

This is introduced by commit dd221bf. Config now has pub license_cache: Option<Arc<dyn LicenseCache>>, and LicenseCache is not RefUnwindSafe. Sending a patch.

@github-actions github-actions Bot force-pushed the release-plz/2025-01-06T14-33-15Z branch from 6f74043 to 7b40434 Compare January 28, 2025 22:25
@github-actions github-actions Bot force-pushed the release-plz/2025-01-06T14-33-15Z branch from 7b40434 to 1af665a Compare January 28, 2025 22:25
@CBenoit
Copy link
Copy Markdown
Member

Benoît Cortier (CBenoit) commented Jan 28, 2025

I slightly updated the changelogs to better reflect the changes.

@CBenoit Benoît Cortier (CBenoit) merged commit e6d6e9d into master Jan 28, 2025
@CBenoit Benoît Cortier (CBenoit) deleted the release-plz/2025-01-06T14-33-15Z branch January 28, 2025 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CBenoit Benoît Cortier (CBenoit) CBenoit approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@devolutionsbot @elmarco @CBenoit