fix(rdpdr): implement Clone and PartialEq on most of efs and esc#388
Merged
Benoît Cortier (CBenoit) merged 3 commits intomasterfrom Feb 29, 2024
Merged
Conversation
Also includes a custom `PartialEq` implementation for `DeviceControlResponse`, and removes `std::io::Error::other` which appears to be a nightly-only feature for now.
Isaiah Becker-Mayer (ibeckermayer)
requested a review
from Benoît Cortier (CBenoit)
Coverage Report 🤖 ⚙️Past: New: Diff: -0.46% [this comment will be updated automatically] |
Benoît Cortier (CBenoit)
changed the title
Clone and PartialEq to most of efs and escClone and PartialEq on most of efs and esc
Benoît Cortier (CBenoit)
deleted the
isaiah/derive-clone-and-partialeq
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also includes a custom
PartialEqimplementation forDeviceControlResponse,and removes.std::io::Error::otherwhich appears to be a nightly-only feature for now