Minicap update to support more devices (included Android 12) #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduce a new option to use a new minicap implementation by specifying --screen-grabber or the env variable SCREEN_GRABBER. The current native minicap is the default and is refered as 'minicap-bin'. The new minicap which is packaged in an apk is usable with 'minicap-apk' and will be used as a fallback. At the moment, this apk is expected to be included in minicap-prebuilt node package at this location minicap-prebuilt/prebuilt/noarch/minicap.apk. STFService.apk has also been updated to take into account Android 12 Signed-off-by: Crepieux Pierre <[email protected]>
|
CI check failed because of minicap-prebuilt dependency. It requires this PR DeviceFarmer/minicap#15 |
koral--
approved these changes
May 31, 2021
| @@ -17,7 +17,7 @@ module.exports = syrup.serial() | |||
| pathutil.vendor('STFService/wire.proto')) | |||
|
|
|||
| var resource = { | |||
| requiredVersion: '2.4.6' | |||
| requiredVersion: '2.4.7' | |||
There was a problem hiding this comment.
There is no such version on https://github.com/DeviceFarmer/STFService.apk repo.
Is it intended to use it here now?
There was a problem hiding this comment.
That's the latest addition from DeviceFarmer/STFService.apk#42
https://github.com/DeviceFarmer/STFService.apk/blob/b75975682a5e4d32c37881515dfc07b3467221d6/app/build.gradle#L29
I think we can release it now.
Minicap is published, now CI fails due to issues detected by linter. |
Signed-off-by: Crepieux Pierre <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduce a new option to use a new minicap
implementation by specifying --screen-grabber or the env
variable SCREEN_GRABBER. The current native minicap is the default
and is refered as 'minicap-bin'. The new minicap which is packaged
in an apk is usable with 'minicap-apk' and will be used as a
fallback.
At the moment, this apk is expected to be included in
minicap-prebuilt node package at this location
minicap-prebuilt/prebuilt/noarch/minicap.apk.
STFService.apk has also been updated to take into account Android 12