Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 37 #42

Merged
merged 2 commits into from
May 20, 2021
Merged

Issue 37 #42

merged 2 commits into from
May 20, 2021

Conversation

pcrepieux
Copy link

Fix issue #37 that prevents the app to run on Android 12

@koral--
Copy link
Member

koral-- commented May 20, 2021

LGTM but DCO check is failing

pcrepieux added 2 commits May 20, 2021 19:57
@pcrepieux
Add another method to wake up phones
9a057b3 
As mentioned in issue 37 existing WakeInjector doesn't work on pixel4 running
Android 12. This commit introduce a new WakeUpWithReasonWakeInjector
that specifies an int reason when calling wakeUp.
This injector is tried with the same currently implemented logic.

Signed-off-by: Crepieux Pierre <[email protected]>
@pcrepieux
Update version code/name and SDK
a498aa4 
Signed-off-by: Crepieux Pierre <[email protected]>
@pcrepieux
Copy link
Author

Ouch yep, noticed it ...
I just forced pushed seconds after your comment

@koral-- koral-- merged commit 41edced into master May 20, 2021
@koral-- koral-- deleted the issue-37 branch May 20, 2021 18:06
@pcrepieux pcrepieux mentioned this pull request Jun 1, 2021
Merged
@Chadarr
Copy link

Chadarr commented Jun 4, 2021

Tried new apk file from https://github.com/DeviceFarmer/STFService.apk/releases/tag/v2.4.7
STFService is finally able to start, device is shown as ready to use in STF web console

But when I start using device, another crash happens

05-31 16:18:58.655  8312  8339 W .cyberagent.st: Accessing hidden method Landroid/view/IWindowManager;->getDefaultDisplayRotation()I (max-target-o, reflection, denied)
05-31 16:18:58.655  8312  8339 W System.err: java.lang.NoSuchMethodException: android.view.IWindowManager$Stub$Proxy.getRotation []
05-31 16:18:58.655  8312  8339 W System.err: 	at java.lang.Class.getMethod(Class.java:2103)
05-31 16:18:58.655  8312  8339 W System.err: 	at java.lang.Class.getMethod(Class.java:1724)
05-31 16:18:58.656  8312  8339 W System.err: 	at jp.co.cyberagent.stf.compat.WindowManagerWrapper.getRotation(WindowManagerWrapper.java:65)
05-31 16:18:58.656  8312  8339 W System.err: 	at jp.co.cyberagent.stf.monitor.RotationMonitor.peek(RotationMonitor.java:54)
05-31 16:18:58.656  8312  8339 W System.err: 	at jp.co.cyberagent.stf.Service$Server$Connection.run(Service.java:369)
05-31 16:18:58.656  8312  8339 W System.err: 	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:462)
05-31 16:18:58.656  8312  8339 W System.err: 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
05-31 16:18:58.656  8312  8339 W System.err: 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
05-31 16:18:58.656  8312  8339 W System.err: 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
05-31 16:18:58.656  8312  8339 W System.err: 	at java.lang.Thread.run(Thread.java:920)

@pcrepieux pcrepieux mentioned this pull request Jul 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koral-- koral-- koral-- approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pcrepieux @koral-- @Chadarr