Workaround for location.origin; fix regressions (#2978, #2975) #3015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreyBelym
force-pushed
the
fix-regressions
branch
from
9cafa1c
to
877b162
Compare
AndreyBelym
force-pushed
the
fix-regressions
branch
from
1179838
to
95ab386
Compare
|
✅ Tests for the commit 95ab386 have passed. See details: |
LavrovArtem
approved these changes
Oct 24, 2018
miherlosev
requested changes
Oct 24, 2018
| @@ -4,6 +4,10 @@ | |||
|
|
|||
| var origin = location.origin; | |||
|
|
|||
| // NOTE: location.origin doesn't exist in IE11 on Windows 10.10240 LTSB | |||
| if (!origin) | |||
| origin = location.protocol + '//' + location.hostname + (location.port ? ':' + location.port : ''); | |||
There was a problem hiding this comment.
You can simplify this:
#2979 (review)
| @@ -152,7 +152,7 @@ module.exports = class MarionetteClient { | |||
| marionetteProtocol: infoPacket.body.marionetteProtocol | |||
| }; | |||
|
|
|||
| this.sessionInfo = await this._getResponse({ command: 'newSession' }); | |||
| this.sessionInfo = await this._getResponse({ command: 'WebDriver:NewSession' }); | |||
There was a problem hiding this comment.
It's a good practice to move all command names to an array of the constants.
miherlosev
approved these changes
Oct 24, 2018
AlexKamaev
approved these changes
Oct 24, 2018
|
❌ Tests for the commit f49d336 have failed. See details: |
|
✅ Tests for the commit f49d336 have passed. See details: |
kirovboris
pushed a commit
to kirovboris/testcafe-phoenix
that referenced
this pull request
Dec 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.