fix failed test after https://github.com/DevExpress/testcafe-hammerhead/pull/1789 #2987
Conversation
AlexKamaev
force-pushed
the
fix_failed_test
branch
from
fb28e3f
to
af7b854
Compare
|
❌ Tests for the commit af7b854 have failed. See details: |
1 similar comment
|
❌ Tests for the commit af7b854 have failed. See details: |
AlexKamaev
changed the title
AlexKamaev
force-pushed
the
fix_failed_test
branch
from
af7b854
to
295a139
Compare
|
✅ Tests for the commit 295a139 have passed. See details: |
|
ping |
| @@ -339,33 +339,31 @@ $(document).ready(function () { | |||
| }); | |||
| }); | |||
|
|
|||
| asyncTest('B237672 - TesCafe throw exception "Access is denied" after trying to get content of iframe in IE browsers', function () { | |||
| let clicked = false; | |||
| asyncTest('B237672 - TesCafe does not throw exception "Access is denied" after trying to get content of iframe', function () { | |||
There was a problem hiding this comment.
Let's do more test improvements:
- rename to
B237672 - TesCafe should not throw an exception "Access is denied" on accessing to a content of the across-domain iframe .attr('src', 'http://www.cross.domain.com')- use any test page instead of the public url- rename
const iframeBody = ...toiframeDocument - add a clear message for
throw new Error();statement (e.g.Click handler for a cross-domain iframe should not be called).
AlexKamaev
force-pushed
the
fix_failed_test
branch
from
295a139
to
40206c6
Compare
|
❌ Tests for the commit 40206c6 have failed. See details: |
|
❌ Tests for the commit 40206c6 have failed. See details: |
| @@ -339,33 +339,31 @@ $(document).ready(function () { | |||
| }); | |||
| }); | |||
|
|
|||
| asyncTest('B237672 - TesCafe throw exception "Access is denied" after trying to get content of iframe in IE browsers', function () { | |||
| let clicked = false; | |||
| asyncTest('B237672 - TesCafe should not throw an exception "Access is denied" on accessing to a content of the across-domain iframe', function () { | |||
There was a problem hiding this comment.
typo in across-domain phrase.
There was a problem hiding this comment.
oops....copy/paste
|
❌ Tests for the commit d537a0f have failed. See details: |
|
❌ Tests for the commit d537a0f have failed. See details: |
|
❌ Tests for the commit d537a0f have failed. See details: |
|
❌ Tests for the commit d537a0f have failed. See details: |
|
❌ Tests for the commit d537a0f have failed. See details: |
|
❌ Tests for the commit d537a0f have failed. See details: |
|
❌ Tests for the commit d537a0f have failed. See details: |
|
Close in favor #3015 |
No description provided.