-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update packages to reduce npm install warnings (closes #769) #1203
Merged
AlexanderMoskovkin
merged 2 commits into
DevExpress:master
from
AndreyBelym:npm-warnings
Feb 2, 2017
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,14 +1,24 @@ | ||
import NODE_VER from '../../utils/node-version'; | ||
|
||
function getOptsForPresetEnv () { | ||
var opts = { targets: { node: 'current' }, loose: true }; | ||
|
||
// NOTE: Disable transforming generators into state-machine for node>=4, because this versions have native generators. | ||
// Also this versions have native template literals, regenerator do not work with them: | ||
// https://github.com/facebook/regenerator/issues/276 | ||
if (NODE_VER >= 4) | ||
opts.exclude = ['transform-regenerator']; | ||
|
||
return opts; | ||
} | ||
|
||
// NOTE: lazy load heavy dependencies | ||
export default function loadBabelLibs () { | ||
return { | ||
babel: require('babel-core'), | ||
presetStage2: require('babel-preset-stage-2'), | ||
transformRuntime: require('babel-plugin-transform-runtime'), | ||
presetES2015Loose: require('babel-preset-es2015').buildPreset({ loose: true }), | ||
|
||
// NOTE: we don't need this preset if we are on older versions of Node | ||
presetES2015Node4: NODE_VER >= 4 ? require('babel-preset-es2015-node4') : null | ||
babel: require('babel-core'), | ||
presetStage2: require('babel-preset-stage-2'), | ||
transformRuntime: require('babel-plugin-transform-runtime'), | ||
presetFallback: require('babel-preset-env').default(null, { loose: true }), | ||
presetEnv: require('babel-preset-env').default(null, getOptsForPresetEnv()) | ||
}; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't use
env
because source will be compiled according to the version of node installed on dev machine. Meanwhile, we should always compile for node 10.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When you use env without
target
option, it behaves likepreset-latest
and will enable all transformations that comes ines2015
,es2016
,es2017
. Options should contain{ target: {node: "current"}}
to enable node feature detection. https://babeljs.io/docs/plugins/preset-env/#usage https://babeljs.io/docs/plugins/preset-latest/