Update packages to reduce npm install warnings (closes #769) #1203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inikulin
suggested changes
Feb 1, 2017
| @@ -1,7 +1,7 @@ | |||
| { | |||
| "compact": false, | |||
| "presets": [ | |||
| ["es2015", { "loose": true }], | |||
| ["env", { "loose": true }], | |||
There was a problem hiding this comment.
We can't use env because source will be compiled according to the version of node installed on dev machine. Meanwhile, we should always compile for node 10.
There was a problem hiding this comment.
When you use env without target option, it behaves like preset-latest and will enable all transformations that comes in es2015, es2016, es2017. Options should contain { target: {node: "current"}} to enable node feature detection. https://babeljs.io/docs/plugins/preset-env/#usage https://babeljs.io/docs/plugins/preset-latest/
|
❌ Tests for the commit 84e06fb have failed. See details: |
|
❌ Tests for the commit 0b49b4b have failed. See details: |
|
✅ Tests for the commit 0b49b4b have passed. See details: |
AndreyBelym
changed the title
AlexanderMoskovkin
approved these changes
Feb 2, 2017
kirovboris
pushed a commit
to kirovboris/testcafe-phoenix
that referenced
this pull request
Dec 18, 2019
DevExpress#1203) * Update packages to reduce npm install warnings (closes DevExpress#769) * Disable regenerator for node>=4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
\cc @inikulin @AlexanderMoskovkin
Remained warnings are from:
gulpDevDep, Up-to-daterecursive-copyDevDep, Up-to-datesaucelabs-connectorDevDep, issue for update