-
Notifications
You must be signed in to change notification settings - Fork 7
Cotainr devcontainer #153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cotainr devcontainer #153
Conversation
|
When I open up that PR in my vscode, the terminal spams |
|
As far as I can see, at least one of these three settings are currently mandatory in |
|
@joasode Did you test with docker (not podman)? I am a little worried about the As we agreed in one of our check-ins, I only cared about podman when setting it up. Hence, in my |
|
@Chroxvi I tested it again, and indeed it seems like this was an error when I was still using docker and not anymore after I changed to podman. |
|
Alright, then I think the |
joasode
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it looks good. (assuming that documentation of this VScode setup follows later)
|
The documentation is in this branch: main...dev_env_docs along with lots of other documentation updates. A PR is expected today or tomorrow. The VSCode documentation include a disclaimer about the dev container setup still being experimental since we are seeing so many issues with permissions for different combinations of OS'es, container runtimes, and versions of the VSCode dev container extension. @juliusroeder's issue is reported upstream: microsoft/vscode-remote-release#11042 I will try to make a similar report for the VSCode dev container v0.417.0 regression, I have encountered. |
* First draft of devcontainer for cotainr * Dev container pre-commit and vscode integrations. * Cleaned up comments in devcontainer.json * Persisted bash history and set LANG in devcontainer.json * Updated dev container to use main branch container. * Added missing relnotes .PHONY target in docs Makefile. * Added common runtime env vars to Dockerfile. * Removed env vars from devcontainer.json that are now in the Dockerfile. * Added comment to devcontainer.json about volume mounts with docker. * Updated devcontainer.json to persist venv in volume mount.
* New and (hopefully) more robust logging reload pytest fixture. * Minor comment update. * Include review suggestion. Co-authored-by: Joachim Sødequist <[email protected]> * Introduce dev container Makefile (#139) * Added a makefile with what we think is reasonable * remove test thingy * Better singularity url * Update makefile to non-privileged run * Add docs building functionality and default target * Fix building docs * Remove userid things * Comments, help and very explicit login * Just a bit .PHONY * Enhance Makefile (#156) * Enhance Makefile * Add review changes * Move quotation mark * singularity debug verbosity level * 5th debug level added. documentation and tests adjusted. * Cotainr devcontainer (#153) * First draft of devcontainer for cotainr * Dev container pre-commit and vscode integrations. * Cleaned up comments in devcontainer.json * Persisted bash history and set LANG in devcontainer.json * Updated dev container to use main branch container. * Added missing relnotes .PHONY target in docs Makefile. * Added common runtime env vars to Dockerfile. * Removed env vars from devcontainer.json that are now in the Dockerfile. * Added comment to devcontainer.json about volume mounts with docker. * Updated devcontainer.json to persist venv in volume mount. * Move to a specific cotainr-conda location rather than a generic conda-location (#66) * Change prefix from /opt/conda to /opt/cotainr/conda * Linting fixes * Change prefix of tests * Fix comments * Handled review comments for caplog leakage fix. --------- Co-authored-by: Joachim Sødequist <[email protected]> Co-authored-by: JuliusRoeder <[email protected]> Co-authored-by: Tor Skovsgaard <[email protected]>

A devcontainer.json for cotainr with a focus (for now) on VS Code with podman.
Also sets a few environment variables in the Dockerfile which are useful for both the dev conatiner setup and the Makefile setup.