Introduce dev container Makefile #139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
joasode
commented
Jun 18, 2025
Contributor
Author
joasode
left a comment
joasode
left a comment
There was a problem hiding this comment.
For me podman does not work without these changes.
joasode
commented
Jun 20, 2025
joasode
commented
Jun 20, 2025
joasode
commented
Jun 20, 2025
joasode
commented
Jun 20, 2025
* Enhance Makefile * Add review changes * Move quotation mark
juliusroeder
approved these changes
Jun 27, 2025
Chroxvi
pushed a commit
that referenced
this pull request
Jul 7, 2025
* Added a makefile with what we think is reasonable * remove test thingy * Better singularity url * Update makefile to non-privileged run * Add docs building functionality and default target * Fix building docs * Remove userid things * Comments, help and very explicit login * Just a bit .PHONY * Enhance Makefile (#156) * Enhance Makefile * Add review changes * Move quotation mark
Chroxvi
added a commit
that referenced
this pull request
Jul 8, 2025
* New and (hopefully) more robust logging reload pytest fixture. * Minor comment update. * Include review suggestion. Co-authored-by: Joachim Sødequist <[email protected]> * Introduce dev container Makefile (#139) * Added a makefile with what we think is reasonable * remove test thingy * Better singularity url * Update makefile to non-privileged run * Add docs building functionality and default target * Fix building docs * Remove userid things * Comments, help and very explicit login * Just a bit .PHONY * Enhance Makefile (#156) * Enhance Makefile * Add review changes * Move quotation mark * singularity debug verbosity level * 5th debug level added. documentation and tests adjusted. * Cotainr devcontainer (#153) * First draft of devcontainer for cotainr * Dev container pre-commit and vscode integrations. * Cleaned up comments in devcontainer.json * Persisted bash history and set LANG in devcontainer.json * Updated dev container to use main branch container. * Added missing relnotes .PHONY target in docs Makefile. * Added common runtime env vars to Dockerfile. * Removed env vars from devcontainer.json that are now in the Dockerfile. * Added comment to devcontainer.json about volume mounts with docker. * Updated devcontainer.json to persist venv in volume mount. * Move to a specific cotainr-conda location rather than a generic conda-location (#66) * Change prefix from /opt/conda to /opt/cotainr/conda * Linting fixes * Change prefix of tests * Fix comments * Handled review comments for caplog leakage fix. --------- Co-authored-by: Joachim Sødequist <[email protected]> Co-authored-by: JuliusRoeder <[email protected]> Co-authored-by: Tor Skovsgaard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.