Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build/ Update ember to 3.18 #47

Closed
wants to merge 1 commit into from
Closed

Build/ Update ember to 3.18 #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,11 @@
},
"scripts": {
"build": "ember build --environment=production",
"lint": "npm-run-all --aggregate-output --continue-on-error --parallel lint:*",
"lint:hbs": "ember-template-lint .",
"lint:js": "eslint .",
"start": "ember serve",
"test": "npm-run-all lint:* test:*",
"test:ember": "ember test",
"test:ember-compatibility": "ember try:each",
"test": "ember test",
"test:all": "ember try:each",
"prettier:js": "prettier-eslint --write --single-quote {addon,app,config,lib,server,tests}/{**/,}*.js"
},
"dependencies": {
Expand All @@ -45,6 +43,7 @@
"ember-circleci": "^1.9.0",
"ember-cli": "~3.18.0",
"ember-cli-dependency-checker": "^3.2.0",
"ember-cli-eslint": "^5.1.0",
"ember-cli-inject-live-reload": "^2.0.2",
"ember-cli-sri": "^2.1.1",
"ember-cli-uglify": "^3.0.0",
Expand All @@ -58,10 +57,8 @@
"ember-source-channel-url": "^2.0.1",
"ember-template-lint": "^2.6.0",
"ember-try": "^1.4.0",
"eslint": "^6.8.0",
"eslint-config-peopledoc": "^2.0.1",
"loader.js": "^4.7.0",
"npm-run-all": "^4.1.5",
Copy link
Member Author

@BlueCutOfficial BlueCutOfficial Aug 21, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GreatWizard can I have your opinion on this? Apparently this dependency has been added when preparing the CI config for 3.18 (#33), but now that I actually lauch ember-cli-update, npm-run-all has been deleted automatically and the commands above reset to a more standard state. Can you explain a bit what it was about?

Note that I first open the PR because your commit about 3.18 was starting by "ci:", so I just haven't seen it, I thought we were still on 3.12. It would be nice to not mess up CI and actual updates in commit wording...

"qunit-dom": "^1.2.0"
},
"engines": {
Expand Down
21 changes: 21 additions & 0 deletions tests/dummy/config/ember-cli-update.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
{
"schemaVersion": "1.0.0",
"packages": [
{
"name": "ember-cli",
"version": "3.16.2",
"blueprints": [
{
"name": "addon",
"outputRepo": "https://github.com/ember-cli/ember-addon-output",
"codemodsSource": "ember-addon-codemods-manifest@1",
"isBaseBlueprint": true,
"options": [
"--yarn",
"--no-welcome"
]
}
]
}
]
}
Loading